Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme - On Spack #16

Merged
merged 16 commits into from
Nov 8, 2024
Merged

Readme - On Spack #16

merged 16 commits into from
Nov 8, 2024

Conversation

fluidnumerics-joe
Copy link
Collaborator

I've added some documentation for installing FTObjectLibrary via spack. Additionally, there are notes on how to contribute new version releases for FTOL to the Spack package manager.

Ideally, you should be able to install Spack using the instructions provided.

fluidnumerics-joe and others added 13 commits June 18, 2021 18:28
* This aids in dependency resolution for other projects, like hohqmesh
* CMake error messages from HOHQMesh suggest it's looking for
ftobjectlibrary-config.cmake
* set_and_check is unknown to CMake when installing HOHQMesh via spack
* FFLAGS default is now set to match the default in the Makefile make
system (Per @sloede suggestion)

* Change CMake config file naming format to camel case (canonical style
of CMAKE, and requested by @sloede).
Co-authored-by: Michael Schlottke-Lakemper <[email protected]>
We believe this can resolve issues with how environment variables are passed to Windows environments when cmake is called.

Co-authored-by: Michael Schlottke-Lakemper <[email protected]>
* Testing to see if this patches the issue with Windows systems builds
* This commit matches @sloede's commit at 23738bc
* Instructions are also included to show how to add a new release to the
Spack package manager
Copy link
Member

@sloede sloede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two minor suggestions, otherwise this LGTM!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@DavidAKopriva DavidAKopriva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. Sorry I didn't know about the review request.

Co-authored-by: Michael Schlottke-Lakemper <[email protected]>
@andrewwinters5000 andrewwinters5000 enabled auto-merge (squash) November 8, 2024 09:43
@andrewwinters5000 andrewwinters5000 merged commit 9a72b7f into main Nov 8, 2024
2 checks passed
@andrewwinters5000 andrewwinters5000 deleted the readme-spack branch November 8, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants