Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First example to actually use smesh #3

Merged
merged 14 commits into from
Jan 26, 2024
Merged

First example to actually use smesh #3

merged 14 commits into from
Jan 26, 2024

Conversation

sloede
Copy link
Member

@sloede sloede commented Jan 25, 2024

No description provided.

@sloede sloede requested a review from bennibolm January 25, 2024 16:36
@sloede sloede marked this pull request as draft January 25, 2024 16:38
@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c457554) 100.00% compared to head (d49f6c3) 100.00%.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main        #3   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            1         7    +6     
=========================================
+ Hits             1         7    +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sloede sloede marked this pull request as ready for review January 25, 2024 22:26
@sloede
Copy link
Member Author

sloede commented Jan 25, 2024

@bennibolm this is ready for review now and can be merged once you're happy

@sloede sloede mentioned this pull request Jan 25, 2024
Closed
@sloede sloede changed the title First example to actualy use smesh First example to actually use smesh Jan 26, 2024
bennibolm
bennibolm approved these changes Jan 26, 2024
View reviewed changes
Copy link
Collaborator

@bennibolm bennibolm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @sloede. Nice explanation on how to actually use it. Here and for smesh 💪

@sloede
Copy link
Member Author

sloede commented Jan 26, 2024

Thanks a lot @sloede. Nice explanation on how to actually use it. Here and for smesh 💪

Thanks! feel free to squash merge if you're happy!

@bennibolm bennibolm merged commit 3d4fb34 into main Jan 26, 2024
13 checks passed
@bennibolm bennibolm deleted the msl/actually-use-libsmesh branch January 26, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bennibolm bennibolm bennibolm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sloede @codecov-commenter @bennibolm