-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Add all routines to set up a voronoi mesh #6
WIP: Add all routines to set up a voronoi mesh #6
Conversation
Maybe we should just not convert anything to Julia types in this package and instead leave it to the user? Alternatively, we could provide additional methods for those functions that accept the return element type as the first argument, i.e., For now, though, I'd just remove the conversion to default Julia types as you did 👍 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 7 34 +27
=========================================
+ Hits 7 34 +27 ☔ View full report in Codecov by Sentry. |
I will add the routine's doctrings in another PR. So, this one here is ready to review/merge. Do you @sloede @simonechiocchetti want to take a look before I merge it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a real review (I will not be able to do this in general), but two minor thoughts
Open issue for later: What variables do I actually need for the implementation of the FV method in Trixi.jl? For which variables does it make sense to convert the array to Julia-typical types (e.g.
Int64
) and when? Can't happen directly after creation, since the following routines require C types.