Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unify parallel 2D tree/p4est mesh rhs! #1111

Merged
merged 1 commit into from
Apr 5, 2022
Merged

Conversation

ranocha
Copy link
Member

@ranocha ranocha commented Apr 5, 2022

@ranocha ranocha requested a review from lchristm April 5, 2022 05:14
@ranocha ranocha mentioned this pull request Apr 5, 2022
4 tasks
Copy link
Member

@sloede sloede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I would have preferred to merge both versions to the first implementation, since it is the "main" routine and often helps new users to look at first, to understand what has changed compared to the serial version. But I'd be OK with it to be merged this way.

@ranocha
Copy link
Member Author

ranocha commented Apr 5, 2022

Isn't that what I did here - using the ParallelTreeMesh{2} version, removing the implementation for the ParallelP4estMesh{2}?

@sloede
Copy link
Member

sloede commented Apr 5, 2022

Isn't that what I did here - using the ParallelTreeMesh{2} version, removing the implementation for the ParallelP4estMesh{2}?

You're right, my bad. Was only looking at line numbers, not filenames. Shouldn't review on the phone 😬

@ranocha ranocha removed the request for review from lchristm April 5, 2022 05:47
@ranocha ranocha enabled auto-merge (squash) April 5, 2022 05:47
@codecov
Copy link

codecov bot commented Apr 5, 2022

Codecov Report

Merging #1111 (a7f2aa8) into main (6d303b3) will increase coverage by 1.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1111      +/-   ##
==========================================
+ Coverage   95.70%   96.75%   +1.04%     
==========================================
  Files         303      303              
  Lines       23890    23876      -14     
==========================================
+ Hits        22863    23099     +236     
+ Misses       1027      777     -250     
Flag Coverage Δ
unittests 96.75% <ø> (+1.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/solvers/dgsem_p4est/dg_2d_parallel.jl 100.00% <ø> (ø)
src/solvers/dgsem_tree/dg_2d_parallel.jl 100.00% <ø> (ø)
src/auxiliary/auxiliary.jl 97.67% <0.00%> (+0.17%) ⬆️
src/solvers/dgsem_p4est/containers.jl 95.59% <0.00%> (+0.74%) ⬆️
src/solvers/dgsem_p4est/dg_3d.jl 100.00% <0.00%> (+5.70%) ⬆️
examples/p4est_3d_dgsem/elixir_euler_sedov.jl 100.00% <0.00%> (+100.00%) ⬆️
...xamples/p4est_3d_dgsem/elixir_euler_free_stream.jl 100.00% <0.00%> (+100.00%) ⬆️
...es/p4est_3d_dgsem/elixir_mhd_shockcapturing_amr.jl 100.00% <0.00%> (+100.00%) ⬆️
...s/p4est_3d_dgsem/elixir_advection_nonconforming.jl 100.00% <0.00%> (+100.00%) ⬆️
...4est_3d_dgsem/elixir_euler_free_stream_extruded.jl 100.00% <0.00%> (+100.00%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d303b3...a7f2aa8. Read the comment docs.

@ranocha ranocha merged commit 1b604a6 into main Apr 5, 2022
@ranocha ranocha deleted the hr/unify_tree_p4est_2d branch April 5, 2022 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants