Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for parallel HDF5 #1504

Merged
merged 14 commits into from
Sep 6, 2023

Conversation

JoshuaLampert
Copy link
Member

In JuliaIO/HDF5.jl#1061 HDF5.jl changed to use Preferences.jl to enable a system-provided HDF5 library.

Copy link
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this work! I agree with @sloede on your question

docs/src/parallelization.md Outdated Show resolved Hide resolved
ranocha
ranocha previously approved these changes Jun 2, 2023
Copy link
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Patch coverage has no change and project coverage change: +11.80% 🎉

Comparison is base (4e6d163) 80.22% compared to head (1239368) 92.02%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1504       +/-   ##
===========================================
+ Coverage   80.22%   92.02%   +11.80%     
===========================================
  Files         414      414               
  Lines       33925    33910       -15     
===========================================
+ Hits        27216    31204     +3988     
+ Misses       6709     2706     -4003     
Flag Coverage Δ
unittests 92.02% <ø> (+11.80%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 128 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoshuaLampert JoshuaLampert added the documentation Improvements or additions to documentation label Aug 30, 2023
@JoshuaLampert
Copy link
Member Author

HDF5.jl v.0.17 has finally been released. So this can be merged.

@ranocha ranocha enabled auto-merge (squash) September 6, 2023 15:50
@ranocha
Copy link
Member

ranocha commented Sep 6, 2023

I just checked that it's using v0.17 of HDF5.jl in at least one CI job. Let's keep fingers crossed that CI passes this time. Thanks for your effort, @JoshuaLampert!

@ranocha ranocha merged commit a7867e7 into trixi-framework:main Sep 6, 2023
@JoshuaLampert JoshuaLampert deleted the parallel-hdf5 branch September 6, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants