Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First-order Finite Volume Method organized with t8code #1627

Closed
wants to merge 55 commits into from

Conversation

bennibolm
Copy link
Contributor

@bennibolm bennibolm commented Sep 7, 2023

This PR adds the implementation of a first-order finite volume scheme.
The mesh is organized with t8code. Therefore, it supports MPI parallelization.

Visualization is implemented using a t8code routine directly and therefore without .h5 files and Trixi2Vtk.

TODOs:

  • Rename mesh to differ from existing T8codeMesh
  • Revise mesh initialization (using existing t8code routines)
  • Possibility to replace messy "exchange ghost data" implementation using u_ from T8codeSolutionContainer
  • Tests

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

  • The PR has a single goal that is clear from the PR title and/or description.
  • All code changes represent a single set of modifications that logically belong together.
  • No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

  • The code can be understood easily.
  • Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
  • There are no redundancies that can be removed by simple modularization/refactoring.
  • There are no leftover debug statements or commented code sections.
  • The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

  • New functions and types are documented with a docstring or top-level comment.
  • Relevant publications are referenced in docstrings (see example for formatting).
  • Inline comments are used to document longer or unusual code sections.
  • Comments describe intent ("why?") and not just functionality ("what?").
  • If the PR introduces a significant change or new feature, it is documented in NEWS.md.

Testing

  • The PR passes all tests.
  • New or modified lines of code are covered by tests.
  • New or modified tests run in less then 10 seconds.

Performance

  • There are no type instabilities or memory allocations in performance-critical parts.
  • If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

  • The correctness of the code was verified using appropriate tests.
  • If new equations/methods are added, a convergence test has been run and the results
    are posted in the PR.

Created with ❤️ by the Trixi.jl community.

src/meshes/t8code_fv_mesh.jl Show resolved Hide resolved
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

Attention: 565 lines in your changes are missing coverage. Please review.

Comparison is base (7f7f058) 96.38% compared to head (824b4e2) 93.57%.
Report is 3 commits behind head on main.

Files Patch % Lines
src/meshes/t8code_fv_mesh.jl 0.00% 189 Missing ⚠️
src/solvers/fv_t8code/containers.jl 0.00% 160 Missing ⚠️
src/solvers/fv_t8code/fv_2d.jl 0.00% 100 Missing ⚠️
src/callbacks_step/analysis_dg2d.jl 0.00% 55 Missing ⚠️
src/callbacks_step/stepsize_dg2d.jl 0.00% 21 Missing ⚠️
...8code_2d_fv/elixir_euler_blast_wave_hybrid_mesh.jl 0.00% 12 Missing ⚠️
src/callbacks_step/save_solution.jl 0.00% 10 Missing ⚠️
...2d_fv/elixir_euler_kelvin_helmholtz_instability.jl 0.00% 9 Missing ⚠️
src/callbacks_step/analysis.jl 0.00% 7 Missing ⚠️
src/meshes/mesh_io.jl 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1627      +/-   ##
==========================================
- Coverage   96.38%   93.57%   -2.82%     
==========================================
  Files         455      460       +5     
  Lines       36391    36941     +550     
==========================================
- Hits        35074    34564     -510     
- Misses       1317     2377    +1060     
Flag Coverage Δ
unittests 93.57% <0.00%> (-2.82%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bennibolm
Copy link
Contributor Author

After T8codeMesh was implemented and merge for DG methods, I rewrote this implementation here to use the existing mesh type. Since many changes were done, I created a new PR and will close the one here.

@bennibolm bennibolm closed this Feb 13, 2024
@bennibolm bennibolm deleted the t8codemesh-FV-1order branch August 1, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants