Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add implementation of subcell bounds check #1672

Merged
merged 20 commits into from
Oct 20, 2023

Implement suggestions for docstring

f4f4146
Select commit
Loading
Failed to load commit list.
Merged

Add implementation of subcell bounds check #1672

Implement suggestions for docstring
f4f4146
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
Codecov / codecov/project succeeded Oct 20, 2023 in 1s

87.21% (+0.73%) compared to bb60b5d

View this Pull Request on Codecov

87.21% (+0.73%) compared to bb60b5d

Details

Codecov Report

Attention: 84 lines in your changes are missing coverage. Please review.

Comparison is base (bb60b5d) 86.47% compared to head (f4f4146) 87.21%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1672      +/-   ##
==========================================
+ Coverage   86.47%   87.21%   +0.73%     
==========================================
  Files         423      425       +2     
  Lines       34312    34379      +67     
==========================================
+ Hits        29671    29981     +310     
+ Misses       4641     4398     -243     
Files Coverage Δ
...ee_2d_dgsem/elixir_euler_shockcapturing_subcell.jl 0.00% <ø> (-100.00%) ⬇️
..._shock_bubble_shockcapturing_subcell_positivity.jl 0.00% <ø> (-100.00%) ⬇️
src/Trixi.jl 43.48% <ø> (ø)
src/solvers/dgsem_tree/subcell_limiters.jl 29.41% <0.00%> (-55.88%) ⬇️
src/solvers/dgsem_tree/subcell_limiters_2d.jl 0.00% <0.00%> (-94.34%) ⬇️
src/callbacks_stage/subcell_bounds_check_2d.jl 0.00% <0.00%> (ø)
src/callbacks_stage/subcell_bounds_check.jl 0.00% <0.00%> (ø)

... and 107 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.