-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make error norm calculation optional #1755
Conversation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1755 +/- ##
=======================================
Coverage 96.24% 96.24%
=======================================
Files 431 431
Lines 34895 34896 +1
=======================================
+ Hits 33582 33583 +1
Misses 1313 1313
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…nto OptionalErrors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds reasonable to me. Could you please document the new behavior in the docstring at the top of this file?
Co-authored-by: Hendrik Ranocha <[email protected]>
Co-authored-by: Hendrik Ranocha <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
The calculation of the error norms is for non MPI runs (i.e., thread-parallel applications) not parallelized and can thus consume a tremendous fraction of computation time for large 2D, 3D systems.$L^2$ and $L^\infty$ errors are for practical applications of interest.
While one might be interested in quantities computed by the
analysis_callback
such as the integrals of internal and kinetic energy, seldomThen, the computation of errors can be avoided by passing
If only
extra_analysis_errors
are desired, one needs to pass in e.g.