Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AnalysisSurfaceIntegral #1812

Merged
Merged
Changes from 1 commit
Commits
Show all changes
57 commits
Select commit Hold shift + click to select a range
99d0659
Add AnalysisSurfaceIntegral
Arpit-Babbar Jan 24, 2024
aee4cfa
Minor change
Arpit-Babbar Jan 24, 2024
9f8daef
Update elixir_euler_subsonic_cylinder.jl
Arpit-Babbar Jan 24, 2024
4054ed5
Apply suggestions from code review
Arpit-Babbar Jan 24, 2024
6b208c8
Fix labels, add tests
Arpit-Babbar Jan 24, 2024
c89e877
Attempt to fix CI
Arpit-Babbar Jan 24, 2024
5b24e2e
Obtain indices from user chosen function
Arpit-Babbar Jan 25, 2024
573ffc3
Formatting
Arpit-Babbar Jan 25, 2024
f565df6
Minor change
Arpit-Babbar Jan 24, 2024
9c0d5e1
Fix labels, add tests
Arpit-Babbar Jan 24, 2024
6de00dd
Attempt to fix CI
Arpit-Babbar Jan 24, 2024
8ada85c
Obtain indices from user chosen function
Arpit-Babbar Jan 25, 2024
a87ac8f
Add new elixirs
Arpit-Babbar Jan 25, 2024
4ac2a21
Add tests for NACA0012
Arpit-Babbar Feb 10, 2024
4d689b1
Fix tolerance, fix CI, add comments
Arpit-Babbar Feb 10, 2024
42e4b2d
Run formatter
Arpit-Babbar Feb 10, 2024
79d5eda
Minor changes
Arpit-Babbar Feb 15, 2024
809c250
Run formatter
Arpit-Babbar Feb 15, 2024
69b0f67
Fix type instability and need for a vector
Arpit-Babbar Feb 15, 2024
feab5b3
Fix typo!
Arpit-Babbar Feb 15, 2024
007bee6
Lower CFL to pass CI?
Arpit-Babbar Feb 16, 2024
1b85765
Reduce amr_interval to pass CI?
Arpit-Babbar Feb 16, 2024
dc8365c
Maybe positivity limiter will fix CI?
Arpit-Babbar Feb 16, 2024
62a57fa
Remove AMR from CI
Arpit-Babbar Feb 16, 2024
2afbc38
That CI fail was on me!
Arpit-Babbar Feb 16, 2024
881810c
Test for write permit
DanielDoehring Mar 19, 2024
d914526
forces via names
DanielDoehring Mar 19, 2024
a198ee0
Boundary Names for other examples
DanielDoehring Mar 19, 2024
45f262a
Merge branch 'main' into surface_pressure_forces
DanielDoehring Mar 19, 2024
ca9c0e8
Shift to SSPRK54 to pass CI?
Arpit-Babbar Mar 19, 2024
b2bec6f
docstrings
DanielDoehring Mar 19, 2024
92c2f68
Merge branch 'surface_pressure_forces' of https://github.com/Arpit-Ba…
DanielDoehring Mar 19, 2024
9fcbb04
alloc tests
DanielDoehring Mar 19, 2024
90ef9a8
fmt
DanielDoehring Mar 19, 2024
e3f6cbc
Apply suggestions from code review
Arpit-Babbar Mar 20, 2024
d1a3507
Format
Arpit-Babbar Mar 20, 2024
0fef9ad
non-allocating BC
DanielDoehring Mar 24, 2024
56f9fa1
Merge branch 'surface_pressure_forces' of https://github.com/Arpit-Ba…
DanielDoehring Mar 24, 2024
89f0559
comments
DanielDoehring Mar 27, 2024
e877dbc
comments
DanielDoehring Mar 27, 2024
71a5509
fmt
DanielDoehring Mar 27, 2024
fd50740
Update src/solvers/dgsem_unstructured/sort_boundary_conditions.jl
DanielDoehring Mar 27, 2024
23306b6
Update src/solvers/dgsem_unstructured/sort_boundary_conditions.jl
DanielDoehring Mar 27, 2024
e0977a9
comments
DanielDoehring Mar 27, 2024
d0a1e3e
make ready for review
DanielDoehring Mar 27, 2024
8aaab77
Merge branch 'main' into surface_pressure_forces
DanielDoehring Mar 27, 2024
ad4e995
typos
DanielDoehring Mar 27, 2024
7779eb1
Apply suggestions from code review
Arpit-Babbar Mar 28, 2024
16fc47f
Some fixes
Arpit-Babbar Mar 28, 2024
545e42a
Format
Arpit-Babbar Mar 28, 2024
d4981c3
Update NEWS.md
DanielDoehring Mar 29, 2024
7376dd4
Update src/callbacks_step/analysis_surface_integral_2d.jl
DanielDoehring Mar 29, 2024
c156876
Polish
DanielDoehring Mar 29, 2024
e76c617
Update examples/p4est_2d_dgsem/elixir_euler_NACA0012airfoil_mach085.jl
DanielDoehring Mar 29, 2024
62cc4c8
increase cfl
DanielDoehring Mar 29, 2024
815a724
fmt
DanielDoehring Mar 29, 2024
2810499
fix
DanielDoehring Mar 29, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add tests for NACA0012
Arpit-Babbar committed Feb 16, 2024
commit 4ac2a21e2da52cab167f3bcddefb99d3af82c2a5
DanielDoehring marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
@@ -18,9 +18,6 @@ U_inf(equations) = mach_inf() * c_inf(equations)

@inline function initial_condition_mach085_flow(x, t,
equations::CompressibleEulerEquations2D)
# set the freestream flow parameters
gasGam = equations.gamma

v1 = U_inf(equations) * cos(aoa())
v2 = U_inf(equations) * sin(aoa())

@@ -46,15 +43,12 @@ volume_integral = VolumeIntegralShockCapturingHG(shock_indicator;
solver = DGSEM(polydeg = polydeg, surface_flux = surface_flux,
volume_integral = volume_integral)

#=
mesh_file = Trixi.download("",
mesh_file = Trixi.download("https://gist.githubusercontent.com/Arpit-Babbar/339662b4b46164a016e35c81c66383bb/raw/8bf94f5b426ba907ace87405cfcc1dcc2ef7cbda/NACA0012.inp",
joinpath(@__DIR__, "NACA0012.inp"))
=#
mesh_file = "NACA0012.inp"

mesh = P4estMesh{2}(mesh_file)

# The boundary of the outer cylinder is constant but subsonic, so we cannot compute the
# The outer boundary is constant but subsonic, so we cannot compute the
# boundary flux for the external information alone. Thus, we use the numerical flux to distinguish
# between inflow and outflow characteristics
@inline function boundary_condition_subsonic_constant(u_inner,
Original file line number Diff line number Diff line change
@@ -44,11 +44,8 @@ polydeg = 3
basis = LobattoLegendreBasis(polydeg)
DanielDoehring marked this conversation as resolved.
Show resolved Hide resolved
solver = DGSEM(polydeg = polydeg, surface_flux = surface_flux)

#=
mesh_file = Trixi.download("",
mesh_file = Trixi.download("https://gist.githubusercontent.com/Arpit-Babbar/339662b4b46164a016e35c81c66383bb/raw/8bf94f5b426ba907ace87405cfcc1dcc2ef7cbda/NACA0012.inp",
joinpath(@__DIR__, "NACA0012.inp"))
=#
mesh_file = "NACA0012.inp"

mesh = P4estMesh{2}(mesh_file, initial_refinement_level = 1)

13 changes: 13 additions & 0 deletions test/test_p4est_2d.jl
Original file line number Diff line number Diff line change
@@ -560,6 +560,19 @@ end
@test isapprox(lift, -6.501138753497174e-15, atol = 1e-13)
@test isapprox(drag, 2.588589856781827, atol = 1e-13)
end

@trixi_testset "elixir_euler_NACA0012airfoil_mach085.jl" begin
@test_trixi_include(joinpath(EXAMPLES_DIR,
"elixir_euler_NACA0012airfoil_mach085.jl"),
l2=[6.054106141023162e-7,
7.4947583731596855e-6,
1.1682455936043817e-5,
0.0007173721760332341],
linf=[0.002472349864955632,
0.043496823453937614,
0.043648671347888836,
3.046213202855595], tspan=(0.0, 0.0001))
end
end

# Clean up afterwards: delete Trixi.jl output directory
14 changes: 14 additions & 0 deletions test/test_parabolic_2d.jl
Original file line number Diff line number Diff line change
@@ -689,6 +689,20 @@ end
@test (@allocated Trixi.rhs!(du_ode, u_ode, semi, t)) < 1000
end
end

@trixi_testset "elixir_navierstokes_NACA0012airfoil_mach08.jl" begin
@test_trixi_include(joinpath(EXAMPLES_DIR,
"elixir_navierstokes_NACA0012airfoil_mach08.jl"),
l2=[0.00018648657393597384,
0.0005076712152849281,
0.00038074587715240566,
0.0021281773710793315],
linf=[0.5153387749819276,
1.1993620992082363,
0.9077214408394708,
5.666071686983816], tspan=(0.0, 0.001),
initial_refinement_level=0)
end
end

# Clean up afterwards: delete Trixi.jl output directory