Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Sc/Enhanced p4est mesh views #2110

Open
wants to merge 77 commits into
base: main
Choose a base branch
from
Open

Conversation

SimonCan
Copy link
Contributor

Enhance p4est mesh views. Allows for a cell-selection for each view.

@SimonCan SimonCan added the enhancement New feature or request label Oct 14, 2024
Copy link
Contributor

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

  • The PR has a single goal that is clear from the PR title and/or description.
  • All code changes represent a single set of modifications that logically belong together.
  • No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

  • The code can be understood easily.
  • Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
  • There are no redundancies that can be removed by simple modularization/refactoring.
  • There are no leftover debug statements or commented code sections.
  • The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

  • New functions and types are documented with a docstring or top-level comment.
  • Relevant publications are referenced in docstrings (see example for formatting).
  • Inline comments are used to document longer or unusual code sections.
  • Comments describe intent ("why?") and not just functionality ("what?").
  • If the PR introduces a significant change or new feature, it is documented in NEWS.md with its PR number.

Testing

  • The PR passes all tests.
  • New or modified lines of code are covered by tests.
  • New or modified tests run in less then 10 seconds.

Performance

  • There are no type instabilities or memory allocations in performance-critical parts.
  • If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

  • The correctness of the code was verified using appropriate tests.
  • If new equations/methods are added, a convergence test has been run and the results
    are posted in the PR.

Created with ❤️ by the Trixi.jl community.

@SimonCan SimonCan changed the title Sterted re-implementing p4est mesh views to be more powerful. Enhanced p4est mesh views Oct 14, 2024
@SimonCan SimonCan changed the title Enhanced p4est mesh views WIP: Sc/Enhanced p4est mesh views Oct 14, 2024
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 65.51724% with 40 lines in your changes missing coverage. Please review.

Project coverage is 77.55%. Comparing base (f9f1a74) to head (72a85fd).

Files with missing lines Patch % Lines
src/meshes/p4est_mesh_view.jl 64.29% 30 Missing ⚠️
src/meshes/mesh_io.jl 16.67% 10 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (f9f1a74) and HEAD (72a85fd). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (f9f1a74) HEAD (72a85fd)
unittests 25 22
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2110       +/-   ##
===========================================
- Coverage   96.42%   77.55%   -18.87%     
===========================================
  Files         489      490        +1     
  Lines       39376    39425       +49     
===========================================
- Hits        37966    30574     -7392     
- Misses       1410     8851     +7441     
Flag Coverage Δ
unittests 77.55% <65.52%> (-18.87%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

SimonCan and others added 22 commits October 15, 2024 11:23
Thius version runs, but does not have all features.
This now goes through with mesh view being equal to the orginal mesh.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
src/meshes/mesh_io.jl Outdated Show resolved Hide resolved
src/meshes/p4est_mesh_view.jl Show resolved Hide resolved
@SimonCan SimonCan requested a review from sloede January 20, 2025 15:49
@SimonCan SimonCan marked this pull request as ready for review January 21, 2025 16:03
jmark
jmark previously approved these changes Jan 23, 2025
src/callbacks_step/analysis_dg2d.jl Outdated Show resolved Hide resolved
src/callbacks_step/save_solution_dg.jl Outdated Show resolved Hide resolved
src/meshes/p4est_mesh_view.jl Outdated Show resolved Hide resolved
src/meshes/p4est_mesh_view.jl Outdated Show resolved Hide resolved
jmark
jmark previously approved these changes Jan 27, 2025
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants