Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add option to subtract a reference state in SaveSolutionCallback #2131

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

export compute_reference_state

3b86205
Select commit
Loading
Failed to load commit list.
Draft

WIP: Add option to subtract a reference state in SaveSolutionCallback #2131

export compute_reference_state
3b86205
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Oct 24, 2024 in 1s

93.85% (-2.50%) compared to 4a81e00

View this Pull Request on Codecov

93.85% (-2.50%) compared to 4a81e00

Details

Codecov Report

Attention: Patch coverage is 26.08696% with 34 lines in your changes missing coverage. Please review.

Project coverage is 93.85%. Comparing base (4a81e00) to head (3b86205).

Files with missing lines Patch % Lines
...es/structured_2d_dgsem/elixir_euler_warm_bubble.jl 0.00% 27 Missing ⚠️
src/callbacks_step/save_solution.jl 53.85% 6 Missing ⚠️
src/callbacks_step/save_solution_dg.jl 83.33% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2131      +/-   ##
==========================================
- Coverage   96.36%   93.85%   -2.50%     
==========================================
  Files         477      477              
  Lines       37753    37778      +25     
==========================================
- Hits        36378    35456     -922     
- Misses       1375     2322     +947

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov