Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial development #1

Merged
merged 40 commits into from
Jan 29, 2024
Merged

Initial development #1

merged 40 commits into from
Jan 29, 2024

Conversation

sloede
Copy link
Member

@sloede sloede commented Jan 16, 2024

This PR is intended to include all basic package infrastructure to make this a proper Julia package and should, once satisfactory, merged using a squash merge.

@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

.github/workflows/ci.yml Show resolved Hide resolved
docs/make.jl Outdated Show resolved Hide resolved
docs/make.jl Outdated Show resolved Hide resolved
AUTHORS.md Show resolved Hide resolved
docs/make.jl Outdated Show resolved Hide resolved
src/trixi_include.jl Outdated Show resolved Hide resolved
AUTHORS.md Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@efaulhaber
Copy link
Member

How is it not properly formatted now?

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@efaulhaber
Copy link
Member

Finally...

.github/workflows/Documenter.yml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/src/index.md Outdated Show resolved Hide resolved
efaulhaber and others added 3 commits January 25, 2024 09:42
Co-authored-by: Hendrik Ranocha <[email protected]>
Co-authored-by: Hendrik Ranocha <[email protected]>
@efaulhaber efaulhaber requested a review from ranocha January 25, 2024 08:43
ranocha
ranocha previously approved these changes Jan 25, 2024
@ranocha
Copy link
Member

ranocha commented Jan 25, 2024

@sloede, @efaulhaber Fine with you?

@efaulhaber
Copy link
Member

Merge?

@ranocha
Copy link
Member

ranocha commented Jan 26, 2024

Fine with me. @sloede?

Copy link
Member Author

@sloede sloede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, I just have a few small questions...

Either way, thanks for preparing this!

README.md Show resolved Hide resolved
docs/make.jl Show resolved Hide resolved
docs/src/index.md Outdated Show resolved Hide resolved
src/trixi_include.jl Outdated Show resolved Hide resolved
src/trixi_include.jl Outdated Show resolved Hide resolved
Co-authored-by: Michael Schlottke-Lakemper <[email protected]>
efaulhaber and others added 6 commits January 29, 2024 10:05
@efaulhaber efaulhaber requested a review from ranocha January 29, 2024 09:55
@sloede sloede merged commit bf6528a into main Jan 29, 2024
12 checks passed
@sloede sloede deleted the initial-development branch January 29, 2024 14:08
@sloede
Copy link
Member Author

sloede commented Jan 29, 2024

Thanks a lot for preparing this, @efaulhaber!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants