Add macro trixi_include_changeprecision to make a double precision elixir run with single precision

[efaulhaber]

This is similar to how Base.include is defined:

include(mod::Module, _path::AbstractString) = _include(identity, mod, _path)
include(mapexpr::Function, mod::Module, _path::AbstractString) = _include(mapexpr, mod, _path)

[coveralls]

Pull Request Test Coverage Report for Build 12471675311

Details

• 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.1%) to 95.122%

---

Totals
Change from base Build 12102967779:	0.1%
Covered Lines:	78
Relevant Lines:	82

---

💛 - Coveralls

[codecov]

Codecov Report

Attention: Patch coverage is 25.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 82.97%. Comparing base (91eb18c) to head (f720829).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
src/trixi_include.jl	25.00%	12 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main      #35       +/-   ##
===========================================
- Coverage   95.00%   82.97%   -12.03%     
===========================================
  Files           5        5               
  Lines          80       94       +14     
===========================================
+ Hits           76       78        +2     
- Misses          4       16       +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sloede]

Fine by me, though I do not really understand most of the changes 😅. Would be good if @ranocha could give the final green light :-)

[ranocha]

Thanks! Why do you need this functionality?

[ranocha]

Suggested change

	Base.include(ex -> replace_assignments(insert_maxiters(mapexpr(ex)); kwargs...),
	mod, elixir)
	Base.include(replace_assignments ∘ insert_maxiters ∘ mapexpr; kwargs...),
	mod, elixir)

[efaulhaber]

Well, the Trixi style guide says:

Executable code should only use ASCII characters.

[ranocha]

@sloede? Composing functions is only available using ∘. From my point of view, ∘ makes it easier to read the code in this case.

[efaulhaber]

Thanks! Why do you need this functionality?

I want to add a macro trixi_include_changeprecision to TrixiParticles that behaves like trixi_include, but uses ChangePrecision.jl to change the precision of an elixir to Float32 to run it on GPUs.

I could also add this macro to TrixiBase, but so far it will only be used by TrixiParticles.

https://github.com/trixi-framework/TrixiParticles.jl/blob/ef/more-gpu-support/src/util.jl#L138-L163

[ranocha]

Thanks! Why do you need this functionality?

I want to add a macro trixi_include_changeprecision to TrixiParticles that behaves like trixi_include, but uses ChangePrecision.jl to change the precision of an elixir to Float32 to run it on GPUs.

I could also add this macro to TrixiBase, but so far it will only be used by TrixiParticles.

https://github.com/trixi-framework/TrixiParticles.jl/blob/ef/more-gpu-support/src/util.jl#L138-L163

This would be nice to have here

[efaulhaber]

I now moved the macro from TrixiParticles to this PR.

[ranocha]

Suggested change

	Most code in the Trixi framework is written in a way that changing all floating-point
	Most code in the Trixi.jl framework is written in a way that changing all floating-point

[ranocha]

I'm not susosure about this. For example, in Trixi.jl, we need to specify additional stuff like RealT = Float32 etc. at several places, e.g.,

https://github.com/trixi-framework/Trixi.jl/blob/c69fe96da676f2521889fc79f68f8e6a6b5a4e7e/examples/unstructured_2d_dgsem/elixir_shallowwater_ec_float32.jl

https://github.com/trixi-framework/Trixi.jl/blob/c69fe96da676f2521889fc79f68f8e6a6b5a4e7e/examples/unstructured_2d_dgsem/elixir_shallowwater_ec_float32.jl#L33

https://github.com/trixi-framework/Trixi.jl/blob/c69fe96da676f2521889fc79f68f8e6a6b5a4e7e/examples/p4est_2d_dgsem/elixir_euler_shockcapturing_ec_float32.jl#L14