Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wet/dry functionality for the 2D Multilayer-SWE #44

Merged
merged 12 commits into from
May 7, 2024

Apply suggestions from code review

132e008
Select commit
Loading
Failed to load commit list.
Merged

Add wet/dry functionality for the 2D Multilayer-SWE #44

Apply suggestions from code review
132e008
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed May 6, 2024 in 0s

97.41% (-1.83%) compared to a684879

View this Pull Request on Codecov

97.41% (-1.83%) compared to a684879

Details

Codecov Report

Attention: Patch coverage is 99.06103% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 97.41%. Comparing base (a684879) to head (132e008).

Files Patch % Lines
...c/callbacks_stage/positivity_shallow_water_dg2d.jl 95.65% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
- Coverage   99.23%   97.41%   -1.83%     
==========================================
  Files          54       58       +4     
  Lines        2228     2436     +208     
==========================================
+ Hits         2211     2373     +162     
- Misses         17       63      +46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.