Ember update #89
Ember update #89
Conversation
TODO - still need to fix pdf.js integration
Looks like the newest one has a lot of api changes. We should upgrade some day
app/router.js
Outdated
| let page = this.get('url'); | ||
| let title = document.title; | ||
| get(this, 'metrics').trackPage({ page, title }); | ||
| if (this.get('fastboot.isFastboot')) { |
There was a problem hiding this comment.
Should this be !this.get('fastboot.isFastboot')?
There was a problem hiding this comment.
Yes! :) weird that this fixed my issue in development though. I was getting fastboot errors about document
Clear deprecation workflow. Suspect most are gone and if not, want to see them.
- Temporary fix for a bug in ember, can be removed on ember-source >= v3.26.0
google analytics to production sites
disabled for mirage to work
- Fix some other lints
Upgrade Ember to v3.24, some addons, various codemods, and beginnings of acceptance tests
|
Hi friends, I'm working on some updates to my fork of this repo. I rebased my code on top of this ember-update branch, and for the most part things are working pretty good. The issue I'm currently trying to fix is that it looks like the code in As far as I can tell this is the The effects of the head.hbs template not getting rendered for me are that the social structured data stuff doesn't work, and the custom css / custom colors files don't get loaded. The fact that the colors don't get loaded is currently preventing me from rolling this out since I really don't like my site with the default green colors. |
This will load custom colors css after whacky default styles
No description provided.