Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and fix IAOs #102

Draft
wants to merge 21 commits into
base: main
Choose a base branch
from
Draft

Review and fix IAOs #102

wants to merge 21 commits into from

Conversation

lweisburn
Copy link
Contributor

Check and fix IAO/PAO code

  • Clean localization code, removing redundant code. Allow for more general localization input options
  • Expose IAO attributes, so that they are no longer hard-coded, and controllable by the user
  • Fix IAO with non-symmetric orthogonalization (i.e. IAO-Boys, IAO-PM, IAO-ER)
  • (TODO: Check/fix frozen core and valence-only, as they deal with the IAO/PAO code)
  • (TODO: Add tests to the localization code)

@lweisburn
Copy link
Contributor Author

In reviewing periodic code, this became a more extended change than intended (sorry)!

The kbe/lo.py and kbe/lo_k.py spread out different functions that are all contained in molbe/lo.py. Further, a lot of these functions are identical. As such, I moved the unique functions between the molecular and periodic code to molbe/lo.py and kbe/lo.py, respectively, and placed the redundant shared ones in shared/external/lo_helper.py.

@lweisburn
Copy link
Contributor Author

Also, important note I want to leave here:

The frozen core procedure is performed differently (at least for IAOs) between the molecular and periodic codes.

In the molecular code, all orbitals are localized together, before the frozen core is identified and removed (from the localized orbitals).

In the periodic code, the frozen core is removed and treated/localized separately from the start.

I will add some warnings to the code to make sure this is very clear

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant