kafka: update sarama dependence #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #21 +/- ##
==========================================
+ Coverage 83.66% 90.42% +6.75%
==========================================
Files 62 10 -52
Lines 5707 1190 -4517
==========================================
- Hits 4775 1076 -3699
+ Misses 749 86 -663
+ Partials 183 28 -155
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
liuzengh
reviewed
Dec 13, 2023
|
is there any progress ? |
liuzengh
added a commit
that referenced
this pull request
Dec 22, 2023
…fka-v1.1.0 (#24) * clickhouse: fix go reference API doc (#18) https://pkg.go.dev/trpc.group/trpc-go/trpc-database/clickhouse * kafka: update sarama dependence (#21) * kafka: update sarama dependence * fix unit test --------- Co-authored-by: Leo <[email protected]>
|
Merged, and a new tag kafka/1.1.0 has been released. https://github.com/trpc-ecosystem/go-database/releases/tag/kafka%2F1.1.0
|
liuzengh
added a commit
that referenced
this pull request
May 20, 2024
* clickhouse: fix go reference API doc (#18) https://pkg.go.dev/trpc.group/trpc-go/trpc-database/clickhouse * kafka: update sarama dependence (#21) * kafka: update sarama dependence * fix unit test * kafka: release v1.1.0 (#22) * workflows: add cla.yaml (#26) * add localcache (#25) * feat: add localcache plugin * chore: update LICENSE * test: add localcache workflow * chore: yaml version * test: flaky test --------- Co-authored-by: Leo <[email protected]> Co-authored-by: Flash-LHR <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update github.com/Shopify/sarama v1.29.1 to github.com/IBM/sarama v1.40.1
Fixes #20