-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add mongodb #28
add mongodb #28
Conversation
All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
LICENSE
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add license for package appearing in go.mod, eg: " mongo-driver"
MIT: goconvey, gomonkey/v2, testify
Apache-2.0: mock, mongo-driver, yaml.v3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add mongo-driver in LICENSE
mongodb/curd.go
Outdated
|
||
// MongoArgFilter mongo operation instruction | ||
const ( | ||
MongoArgFilter = "filter" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These constants do not need to be exported
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
modify these constants to be non-exported
mongodb/codec.go
Outdated
|
||
// default codec | ||
var ( | ||
DefaultClientCodec = &ClientCodec{} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do not need to be exported
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
mongodb/plugin.go
Outdated
|
||
// MongoPlugin is used for plug-in default initialization, | ||
// used to load mongo proxy connection parameter configuration. | ||
type MongoPlugin struct{} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do not need to be exported
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
Please add some PR description |
@sandyskies done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Updated the relevant dependencies and LICENSE.
Open source mongodb to GitHub trpc ecosystem.