Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mongodb #28

Merged
merged 4 commits into from
May 22, 2024
Merged

Conversation

YoungFr
Copy link
Contributor

@YoungFr YoungFr commented May 20, 2024

Updated the relevant dependencies and LICENSE.
Open source mongodb to GitHub trpc ecosystem.

@YoungFr YoungFr requested a review from a team as a code owner May 20, 2024 09:28
Copy link

github-actions bot commented May 20, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@YoungFr
Copy link
Contributor Author

YoungFr commented May 20, 2024

I have read the CLA Document and I hereby sign the CLA

liuzengh added a commit to trpc-group/cla-database that referenced this pull request May 20, 2024
LICENSE Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add license for package appearing in go.mod, eg: " mongo-driver"

MIT: goconvey, gomonkey/v2, testify

Apache-2.0: mock, mongo-driver, yaml.v3

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add mongo-driver in LICENSE

mongodb/curd.go Outdated

// MongoArgFilter mongo operation instruction
const (
MongoArgFilter = "filter"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These constants do not need to be exported

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modify these constants to be non-exported

mongodb/codec.go Outdated

// default codec
var (
DefaultClientCodec = &ClientCodec{}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do not need to be exported

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed


// MongoPlugin is used for plug-in default initialization,
// used to load mongo proxy connection parameter configuration.
type MongoPlugin struct{}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do not need to be exported

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@sandyskies
Copy link
Contributor

Please add some PR description

@YoungFr
Copy link
Contributor Author

YoungFr commented May 21, 2024

Please add some PR description

@sandyskies done

Copy link
Contributor

@liuzengh liuzengh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sandyskies sandyskies merged commit d476e18 into trpc-ecosystem:main May 22, 2024
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 22, 2024
@YoungFr YoungFr deleted the YoungFr/open_source_mongodb branch May 23, 2024 08:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants