Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optim bazel #52

Closed
wants to merge 1 commit into from
Closed

optim bazel #52

wants to merge 1 commit into from

Conversation

wu-hanqing
Copy link

@wu-hanqing wu-hanqing commented Oct 19, 2023

  • add .bazelversion to support bazelisk
  • add .bazelignore and exclude cmake_third_party to fix this

@github-actions
Copy link

github-actions bot commented Oct 19, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@lioncfliu
Copy link
Contributor

Thank you for contributing code, please add a comment with "I have read the CLA Document and I hereby sign the CLA" to sign CLA.

e.g.
image

BUILD.bazel Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All BUILD files in this project are bazel BUILD files. The meaning is clear. And we won't define another BUILD file that is not a bazle BUILD file.

Is there exists any special advantage to change filename from BUILD into BUILD.bazel ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late reply. Of course, bazel supports both forms, but on some MacOS platforms, the file system is not case-sensitive, which can result in not being able to create a build folder in the working directory.

If this is not a problem, I will drop this modification.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for not checking the email notification in time when your replied.

tRPC-Cpp has no plan to support other platforms expect linux. This modification seems no need.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for not checking the email notification in time when your replied.

tRPC-Cpp has no plan to support other platforms expect linux. This modification seems no need.

Fixed

@wu-hanqing
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

liuzengh added a commit to trpc-group/cla-database that referenced this pull request Dec 8, 2023
@wu-hanqing wu-hanqing requested a review from weimch December 8, 2023 15:09
@wu-hanqing wu-hanqing closed this Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants