-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optim bazel #52
optim bazel #52
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
BUILD.bazel
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All BUILD files in this project are bazel BUILD files. The meaning is clear. And we won't define another BUILD file that is not a bazle BUILD file.
Is there exists any special advantage to change filename from BUILD into BUILD.bazel ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late reply. Of course, bazel supports both forms, but on some MacOS platforms, the file system is not case-sensitive, which can result in not being able to create a build
folder in the working directory.
If this is not a problem, I will drop this modification.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for not checking the email notification in time when your replied.
tRPC-Cpp has no plan to support other platforms expect linux. This modification seems no need.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for not checking the email notification in time when your replied.
tRPC-Cpp has no plan to support other platforms expect linux. This modification seems no need.
Fixed
66db257
to
57a42c8
Compare
I have read the CLA Document and I hereby sign the CLA |
.bazelversion
to support bazelisk.bazelignore
and excludecmake_third_party
to fix this