Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common(ports): detect potential issue with port names #29051

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

stavros-k
Copy link
Collaborator

@stavros-k stavros-k commented Nov 9, 2024

Description

⚒️ Fixes #29041

⚙️ Type of change

  • ⚙️ Feature/App addition
  • 🪛 Bugfix
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🔃 Refactor of current code

🧪 How Has This Been Tested?

📃 Notes:

✔️ Checklist:

  • ⚖️ My code follows the style guidelines of this project
  • 👀 I have performed a self-review of my own code
  • #️⃣ I have commented my code, particularly in hard-to-understand areas
  • 📄 I have made corresponding changes to the documentation
  • ⚠️ My changes generate no new warnings
  • 🧪 I have added tests to this description that prove my fix is effective or that my feature works
  • ⬆️ I increased versions for any altered app according to semantic versioning
  • I made sure the title starts with feat(chart-name):, fix(chart-name): or chore(chart-name):

➕ App addition

If this PR is an app addition please make sure you have done the following.

  • 🖼️ I have added an icon in the Chart's root directory called icon.png

Please don't blindly check all the boxes. Read them and only check those that apply.
Those checkboxes are there for the reviewer to see what is this all about and
the status of this PR with a quick glance.

Copy link

github-actions bot commented Nov 9, 2024

✅ Deploy Preview ready!

Name Link
🔨 Latest commit 4fb2ae0
🔍 Latest deploy log https://github.com/truecharts/public/actions/runs/11781697160
😎 Deploy Preview Url
🌳 Environment

@stavros-k stavros-k marked this pull request as ready for review November 9, 2024 18:27
@PrivatePuffin PrivatePuffin enabled auto-merge (squash) November 11, 2024 15:42
@PrivatePuffin PrivatePuffin merged commit 3b2ef37 into master Nov 11, 2024
106 checks passed
@PrivatePuffin PrivatePuffin deleted the port-sorting-detection branch November 11, 2024 15:58
@truecharts-admin
Copy link
Collaborator

This PR is locked to prevent necro-posting on closed PRs. Please create a issue or contact staff on discord if you want to further discuss this

@truecharts truecharts locked as resolved and limited conversation to collaborators Nov 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Common]: Try detecting issues with PATCH in container ports
3 participants