-
-
Notifications
You must be signed in to change notification settings - Fork 622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(authelia): authelia configuration.yaml configmap for public client secret should be empty string #29496
Open
malarinv
wants to merge
9
commits into
truecharts:master
Choose a base branch
from
malarinv:authelia_oidc_public
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malarinv
requested review from
PrivatePuffin,
alfi0812,
kqmaverick,
Heavybullets8 and
StevenMcElligott
as code owners
November 17, 2024 18:04
Co-authored-by: Kjeld Schouten <[email protected]> Signed-off-by: Malar Kannan <[email protected]>
stavros-k
reviewed
Dec 11, 2024
Co-authored-by: Stavros Kois <[email protected]> Signed-off-by: Kjeld Schouten <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See https://www.authelia.com/configuration/identity-providers/openid-connect/clients/#client_secret for explanation
⚒️ Fixes #
⚙️ Type of change
🧪 How Has This Been Tested?
📃 Notes:
This would fix support for oidc auth with authelia for dashy chart
✔️ Checklist:
feat(chart-name):
,fix(chart-name):
orchore(chart-name):
➕ App addition
If this PR is an app addition please make sure you have done the following.
icon.png
Please don't blindly check all the boxes. Read them and only check those that apply.
Those checkboxes are there for the reviewer to see what is this all about and
the status of this PR with a quick glance.