Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-132330 / 25.04 / Update TrueNAS Brand #11318

Merged
merged 18 commits into from
Feb 4, 2025
Merged

NAS-132330 / 25.04 / Update TrueNAS Brand #11318

merged 18 commits into from
Feb 4, 2025

Conversation

denysbutenko
Copy link
Member

@denysbutenko denysbutenko commented Jan 9, 2025

Changes:

  • Updated svg files related for TrueNAS logo
  • Used TrueNAS Community Edition for SCALE
  • Used TrueNAS Enterprise for SCALE Enterprise
  • Added ix-truenas-logo component
  • Updated favicons

Testing:

Check affected places for regressions on desktop and mobile.

Downstream

Affects Reasoning
Documentation New branding, all screenshots needs to be updated

@denysbutenko denysbutenko requested a review from a team as a code owner January 9, 2025 15:49
@denysbutenko denysbutenko requested review from RehanY147 and removed request for a team January 9, 2025 15:49
@bugclerk
Copy link
Contributor

bugclerk commented Jan 9, 2025

@bugclerk bugclerk changed the title Nas 132330 NAS-132330 / 25.04 / Nas 132330 Jan 9, 2025
@denysbutenko denysbutenko changed the title NAS-132330 / 25.04 / Nas 132330 NAS-132330 / 25.04 / Update TrueNAS Brand Jan 9, 2025
@denysbutenko denysbutenko requested a review from undsoft January 9, 2025 15:58
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 95.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 83.23%. Comparing base (4d87447) to head (a7b5d43).
Report is 2 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ules/layout/admin-layout/admin-layout.component.ts 0.00% 2 Missing ⚠️
...yout/topbar/truenas-logo/truenas-logo.component.ts 97.77% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11318      +/-   ##
==========================================
+ Coverage   83.22%   83.23%   +0.01%     
==========================================
  Files        1650     1651       +1     
  Lines       58875    58922      +47     
  Branches     6282     6297      +15     
==========================================
+ Hits        48998    49044      +46     
- Misses       9877     9878       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@undsoft undsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logo in the sidebar is too large and not centered visually.
Also please update truenas-logo-mark and related icons and the favicon with the single box like the new logo.

src/app/helptext/about.ts Outdated Show resolved Hide resolved
@denysbutenko denysbutenko requested review from undsoft and removed request for RehanY147 January 14, 2025 17:03
@undsoft
Copy link
Collaborator

undsoft commented Jan 16, 2025

Not entirely happy with how new logos look in sidebar. Investigating what we can do about it.

@undsoft undsoft added the backport-25.04-RC.1 Fangtooth RC1 label Jan 27, 2025
Copy link
Collaborator

@undsoft undsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks mostly okay. I would add margin-right: 4px; on .logo-text because the logo doesn't look centered in the sidebar visually.
And also, we may need to use white version for some of the themes, because current blue logo doesn't work too well with some themes.

@undsoft undsoft added backport-25.04-BETA.1 Fangtooth Beta and removed blocked labels Feb 3, 2025
@denysbutenko
Copy link
Member Author

And also, we may need to use white version for some of the themes, because current blue logo doesn't work too well with some themes.

We can change this anytime

protected useWhite = computed(() => {
return this.color() === 'white' || this.isBlueTheme();
});

@bugclerk
Copy link
Contributor

bugclerk commented Feb 4, 2025

JIRA ticket https://ixsystems.atlassian.net/browse/NAS-132330 is targeted to the following versions which have not received their corresponding PRs: 25.10

@bugclerk
Copy link
Contributor

bugclerk commented Feb 4, 2025

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Feb 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants