-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NAS-132330 / 25.04 / Update TrueNAS Brand #11318
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #11318 +/- ##
==========================================
+ Coverage 83.22% 83.23% +0.01%
==========================================
Files 1650 1651 +1
Lines 58875 58922 +47
Branches 6282 6297 +15
==========================================
+ Hits 48998 49044 +46
- Misses 9877 9878 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logo in the sidebar is too large and not centered visually.
Also please update truenas-logo-mark
and related icons and the favicon with the single box like the new logo.
Not entirely happy with how new logos look in sidebar. Investigating what we can do about it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks mostly okay. I would add margin-right: 4px;
on .logo-text
because the logo doesn't look centered in the sidebar visually.
And also, we may need to use white version for some of the themes, because current blue logo doesn't work too well with some themes.
We can change this anytime webui/src/app/modules/layout/topbar/truenas-logo/truenas-logo.component.ts Lines 37 to 39 in 1008c98
|
JIRA ticket https://ixsystems.atlassian.net/browse/NAS-132330 is targeted to the following versions which have not received their corresponding PRs: 25.10 |
This PR has been merged and conversations have been locked. |
Changes:
TrueNAS Community Edition
for SCALETrueNAS Enterprise
for SCALE Enterpriseix-truenas-logo
componentTesting:
Check affected places for regressions on desktop and mobile.
Downstream