-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NAS-133356 / 25.04 / Migrate devices page to master-detail-view #11361
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #11361 +/- ##
==========================================
+ Coverage 82.94% 83.22% +0.28%
==========================================
Files 1672 1673 +1
Lines 59959 59975 +16
Branches 6308 6308
==========================================
+ Hits 49733 49917 +184
+ Misses 10226 10058 -168 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've noticed a regression in click handler for a Add VDEV
Jan-21-2025.10-02-23.mp4
And there's another regression on a small screen: detail view won't show up
Jan-21-2025.10-13-06.mp4
Error details:
error-handler.service.ts:42 TypeError: Cannot read properties of undefined (reading 'focus')
at devices.component.ts:126:92
Optionally, maybe it's a good time to make a small improvement to the link Manage Global SED Password, and change it's click handler to behave similar to a click on the System > Advanced Settings > Self-Encrypting Drive > SED password search result after user types in "SED" at the global search text box
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
This reverts commit 5b93173.
JIRA ticket https://ixsystems.atlassian.net/browse/NAS-133356 is targeted to the following versions which have not received their corresponding PRs: 25.04-RC.1, 25.10 |
This PR has been merged and conversations have been locked. |
Changes:
Migrates the devices page in storage module to use the master-detail-view component
Testing:
Look out for regressions and code review should be enough.