Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-133356 / 25.04 / Migrate devices page to master-detail-view #11361

Merged
merged 21 commits into from
Jan 29, 2025

Conversation

RehanY147
Copy link
Contributor

Changes:

Migrates the devices page in storage module to use the master-detail-view component

Testing:

Look out for regressions and code review should be enough.

@RehanY147 RehanY147 requested a review from a team as a code owner January 20, 2025 13:37
@RehanY147 RehanY147 requested review from bvasilenko and removed request for a team January 20, 2025 13:37
@bugclerk bugclerk changed the title Migrate devices page to master-detail-view NAS-133356 / 25.04 / Migrate devices page to master-detail-view Jan 20, 2025
@bugclerk
Copy link
Contributor

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 81.81818% with 26 lines in your changes missing coverage. Please review.

Project coverage is 83.22%. Comparing base (a766a09) to head (7bc9f98).
Report is 3 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...s/components/devies-list/devices-list.component.ts 77.22% 23 Missing ⚠️
...pages/storage/modules/devices/devices.component.ts 94.28% 2 Missing ⚠️
...ge/modules/devices/stores/devices-store.service.ts 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11361      +/-   ##
==========================================
+ Coverage   82.94%   83.22%   +0.28%     
==========================================
  Files        1672     1673       +1     
  Lines       59959    59975      +16     
  Branches     6308     6308              
==========================================
+ Hits        49733    49917     +184     
+ Misses      10226    10058     -168     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bvasilenko bvasilenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've noticed a regression in click handler for a Add VDEV

Jan-21-2025.10-02-23.mp4

And there's another regression on a small screen: detail view won't show up

Jan-21-2025.10-13-06.mp4

Error details:

error-handler.service.ts:42 TypeError: Cannot read properties of undefined (reading 'focus')
    at devices.component.ts:126:92

Optionally, maybe it's a good time to make a small improvement to the link Manage Global SED Password, and change it's click handler to behave similar to a click on the System > Advanced Settings > Self-Encrypting Drive > SED password search result after user types in "SED" at the global search text box

@RehanY147 RehanY147 requested a review from bvasilenko January 21, 2025 11:54
Copy link
Contributor

@bvasilenko bvasilenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@RehanY147 RehanY147 enabled auto-merge (squash) January 26, 2025 05:09
@undsoft undsoft added backport-25.04-RC.1 Fangtooth RC1 and removed backport-25.04-RC.1 Fangtooth RC1 labels Jan 27, 2025
@RehanY147 RehanY147 merged commit 838e4e7 into master Jan 29, 2025
11 checks passed
@RehanY147 RehanY147 deleted the NAS-133356 branch January 29, 2025 08:14
@bugclerk
Copy link
Contributor

JIRA ticket https://ixsystems.atlassian.net/browse/NAS-133356 is targeted to the following versions which have not received their corresponding PRs: 25.04-RC.1, 25.10

@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Jan 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants