Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NAS-133816 / 25.10 / YAML is not available during edit when app is created #11428

Merged
merged 2 commits into from
Jan 29, 2025
Merged

NAS-133816 / 25.10 / YAML is not available during edit when app is created #11428

merged 2 commits into from
Jan 29, 2025
+37 −10

Conversation

AlexKarpov98
Copy link
Contributor

Testing: see ticket.

Result:

Screen.Recording.2025-01-28.at.14.26.12.mov

@AlexKarpov98 AlexKarpov98 added the backport-25.04-RC.1 Fangtooth RC1 label Jan 28, 2025
@AlexKarpov98 AlexKarpov98 self-assigned this Jan 28, 2025
@AlexKarpov98 AlexKarpov98 marked this pull request as ready for review January 28, 2025 12:29
@AlexKarpov98 AlexKarpov98 requested a review from a team as a code owner January 28, 2025 12:29
@AlexKarpov98 AlexKarpov98 requested review from undsoft and removed request for a team January 28, 2025 12:29
@bugclerk bugclerk changed the title NAS-133816: YAML is not available during edit when app is created NAS-133816 / 25.10 / YAML is not available during edit when app is created Jan 28, 2025
@bugclerk
Copy link
Contributor

Jira URL: https://ixsystems.atlassian.net/browse/NAS-133816

@codecov Codecov
Copy link

codecov bot commented Jan 28, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 84.21053% with 3 lines in your changes missing coverage. Please review.

Project coverage is 82.94%. Comparing base (a766a09) to head (2403416).
Report is 4 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...nents/custom-app-form/custom-app-form.component.ts 84.21% 3 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #11428   +/-   ##
=======================================
  Coverage   82.94%   82.94%           
=======================================
  Files        1672     1672           
  Lines       59959    59971   +12     
  Branches     6308     6308           
=======================================
+ Hits        49733    49743   +10     
- Misses      10226    10228    +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

undsoft
undsoft approved these changes Jan 28, 2025
View reviewed changes
Copy link
Collaborator

@undsoft undsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I can see previous config now.

@AlexKarpov98 AlexKarpov98 merged commit ff7fb2c into master Jan 29, 2025
9 checks passed
@AlexKarpov98 AlexKarpov98 deleted the NAS-133816 branch January 29, 2025 09:44
@bugclerk bugclerk mentioned this pull request Jan 29, 2025
Merged
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Jan 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@undsoft undsoft undsoft approved these changes

Assignees

@AlexKarpov98 AlexKarpov98

Labels
backport-25.04-RC.1 Fangtooth RC1 backported no-time-tracked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexKarpov98 @bugclerk @undsoft