Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create trulens-semconv package. #1669

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

sfc-gh-dkurokawa
Copy link
Contributor

@sfc-gh-dkurokawa sfc-gh-dkurokawa commented Nov 26, 2024

Description

Create trulens-semconv package.

This is just part 1 of breaking up Piotr's PR here: https://github.com/truera/trulens/pull/1608/files since he left now.

Other details good to know for developers

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • New Tests
  • This change includes re-generated golden test results
  • This change requires a documentation update

Important

Introduce trulens-semconv package for semantic conventions and update dependencies and tests accordingly.

  • New Package:
    • Create trulens-semconv package with semantic conventions for TruLens spans.
    • Add README.md and pyproject.toml for trulens-semconv.
    • Implement __init__.py and trace.py in trulens/semconv.
  • Dependencies:
    • Add trulens-semconv, opentelemetry-api, and opentelemetry-sdk as optional dependencies in core/pyproject.toml.
    • Update server_side_evaluation_artifacts.py to include trulens-semconv and OpenTelemetry packages.
  • Build and Packaging:
    • Update zip_wheels.sh to include trulens-semconv in the packaging process.
  • Testing:
    • Modify test_context_variables.py to initialize SnowflakeConnector with init_server_side_with_staged_packages=True.

This description was created by Ellipsis for 521ca3c. It will automatically update as commits are pushed.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@sfc-gh-dkurokawa sfc-gh-dkurokawa marked this pull request as ready for review November 26, 2024 19:04
@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Nov 26, 2024
@@ -45,16 +45,18 @@ alembic = "^1.8.1"
nest-asyncio = "^1.5"
python-dotenv = ">=0.21,<2.0"
importlib-resources = "^6.0"
trulens-semconv = { version = "^1.0.0", optional = true }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we using trulens-semconv in core?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants