Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update probe.js #44

Merged
merged 1 commit into from
Feb 6, 2023
Merged

Update probe.js #44

merged 1 commit into from
Feb 6, 2023

Conversation

morph3
Copy link
Contributor

@morph3 morph3 commented Feb 2, 2023

This probe has the issue stated in the link below

This commit fixes it.

This probe has the issue stated in the link below

* mandatoryprogrammer/xsshunter-express#11 

This commit fixes it.
@dustin-decker
Copy link
Contributor

Could it try again after the page loads rather than setting empty values?

@dustin-decker dustin-decker requested a review from dxa4481 February 2, 2023 23:12
@morph3
Copy link
Contributor Author

morph3 commented Feb 2, 2023

Well actually, you had the line below commented out in the probe. That's my bad, probe still triggers an alert but it looks like it's making not capture the DOM too.

probe_return_data['text'] = get_dom_text();

I just focused on making it capture and not error out whatever happens but that sounds doable too, might give it a shot.

@dustin-decker dustin-decker merged commit b041699 into trufflesecurity:main Feb 6, 2023
@dustin-decker
Copy link
Contributor

Thanks, for the contribution, this is a good improvement for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants