Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mypy run_from to respect nested setups #570

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Conversation

TylerJang27
Copy link
Collaborator

Multi-language repos that do not include pyproject.toml at their workspace root will require mypy to respect their relevant configs. This uses the new run_from key to support this, and we can roll this out for other linters as needed.

Will require a CLI version (and required version) bump once the relevant changes are released.

Copy link

trunk-io bot commented Nov 29, 2023

⏱️ 22m total CI duration on this PR
Job Cumulative Duration Recent Runs
Linter Tests macOS 7m 🟥🟩
Windows Linter Tests 4m 🟥🟩
Linter Tests Linux 3m 🟥🟩
CodeQL-Build 3m 🟩🟩
Trunk Check runner [linux] 2m 🟥🟩
Tool Tests (macOS) 1m 🟩
Repo Tests / Plugin Tests 56s 🟥🟩
Tool Tests (Linux) 52s 🟩
Detect changed files 14s 🟩🟩
Aggregate Test Results 4s 🟥🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

@TylerJang27 TylerJang27 marked this pull request as ready for review December 7, 2023 00:05
@TylerJang27 TylerJang27 requested review from det and laurit17 December 7, 2023 00:06
@TylerJang27 TylerJang27 merged commit 01f7b59 into main Dec 7, 2023
14 checks passed
@TylerJang27 TylerJang27 deleted the tyler/mypy-run-from branch December 7, 2023 00:13
pat-trunk-io pushed a commit that referenced this pull request Jan 22, 2024
Multi-language repos that do not include `pyproject.toml` at their
workspace root will require mypy to respect their relevant configs. This
uses the new `run_from` key to support this, and we can roll this out
for other linters as needed.

Will require a CLI version (and required version) bump once the relevant
changes are released.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants