Define GitKraken CLI in tools #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
EliSchleifer
commented
Dec 7, 2023
•
EliSchleifer
commented
- Define GitKraken CLI in tools
- Enable shell-hooks in the repo
⏱️ 53m total CI duration on this PR
|
TylerJang27
reviewed
Dec 7, 2023
.trunk/trunk.yaml
Outdated
Comment on lines
7
to
8
| path_add: | ||
| - "${workspace}/tools" |
There was a problem hiding this comment.
Please remove this bit, it's not relevant here
There was a problem hiding this comment.
Should be
shell_hooks:
enforce: true
tools/gk/gk.test.ts
Outdated
| @@ -0,0 +1,12 @@ | |||
| import { makeToolTestConfig, toolTest } from "tests"; | |||
|
|
|||
| toolTest({ | |||
There was a problem hiding this comment.
prefer toolInstallTest. We're in the process of migrating things over. It streamlines this boilerplate
pat-trunk-io
pushed a commit
that referenced
this pull request
Jan 22, 2024
- Define GitKraken CLI in tools - Enable shell-hooks in the repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.