Fix run_from for iwyu #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ 1h 3m total CI duration on this PR
|
|
Needs new CLI changes before the test coverage component can land |
TylerJang27
force-pushed
the
tyler/fix-iwyu
branch
from
72dbd9d to
b7bb244
Compare
TylerJang27
force-pushed
the
tyler/fix-iwyu
branch
from
4db77dd to
9989357
Compare
sxlijin
approved these changes
Jan 8, 2024
pat-trunk-io
pushed a commit
that referenced
this pull request
Jan 22, 2024
This was "working" before because the default is to just fallback to the
workspace root.
Also includes better test coverage for this and the relevant CLI
`run_from: ${compile_command}` fix.
Also fixes a prettier snapshot with the latest upstream testing changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was "working" before because the default is to just fallback to the workspace root.
Also includes better test coverage for this and the relevant CLI
run_from: ${compile_command}fix.Also fixes a prettier snapshot with the latest upstream testing changes.