Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-add missing snapshots #611

Closed
wants to merge 1 commit into from

Conversation

trunk-open-pr-bot[bot]
Copy link
Contributor

Copy link

trunk-io bot commented Jan 5, 2024

⏱️ 10m total CI duration on this PR
Job Cumulative Duration Recent Runs
Windows Linter Tests 5m 🟩
Linter Tests macOS 2m 🟩
CodeQL-Build 1m 🟩
Linter Tests Linux 56s 🟩
Trunk Check runner [linux] 28s 🟩
Repo Tests / Plugin Tests 24s 🟩
Detect changed files 8s 🟩
Aggregate Test Results 3s 🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

@TylerJang27
Copy link
Collaborator

This PR demonstrates a bug, fixed in #612

@TylerJang27 TylerJang27 closed this Jan 5, 2024
TylerJang27 added a commit that referenced this pull request Jan 5, 2024
There was a bug where if all tests passed it would obscure the detection
of a mismatch. Mismatched version should never trigger snapshot
auto-generation. This caused this
[PR](#611) to be erroneously
generated.
pat-trunk-io pushed a commit that referenced this pull request Jan 22, 2024
There was a bug where if all tests passed it would obscure the detection
of a mismatch. Mismatched version should never trigger snapshot
auto-generation. This caused this
[PR](#611) to be erroneously
generated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant