Fix snapshot auto-generation bug #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ 18m total CI duration on this PR
|
det
approved these changes
Jan 8, 2024
pat-trunk-io
pushed a commit
that referenced
this pull request
Jan 22, 2024
Fixes another bug in snapshot generation that led to the creation of #618. Depending on the order of the test parsing, mismatched versions were being treated as a "pass", which was an overloaded state and led to snapshot auto-generation. I added the `Skipped` failure enum type, which makes these states more explicit and fixes the underlying issue. I also tested manually that this still has the fix from #612.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes another bug in snapshot generation that led to the creation of #618. Depending on the order of the test parsing, mismatched versions were being treated as a "pass", which was an overloaded state and led to snapshot auto-generation. I added the
Skippedfailure enum type, which makes these states more explicit and fixes the underlying issue.I also tested manually that this still has the fix from #612.