Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Docs): Add lint ignore conversion guide #969

Merged
merged 2 commits into from
Jan 30, 2025
Merged

Conversation

TylerJang27
Copy link
Collaborator

@TylerJang27 TylerJang27 commented Jan 30, 2025

A user requested a comparison of ignore capabilities and styles for some of our top python linters.

For now, I've added repo docs on this for:

  • ruff
  • mypy
  • markdownlint
  • eslint

Copy link

trunk-io bot commented Jan 30, 2025

⏱️ 1h 59m total CI duration on this PR
Job Cumulative Duration Recent Runs
Linter Tests ubuntu-latest 44m 🟥🟥
Linter Tests macOS 42m 🟩🟥
Tool Tests (ubuntu-latest) 15m 🟩🟩
Tool Tests (macOS) 8m 🟩🟥
CodeQL-Build 3m 🟩🟩
Action Tests 3m 🟩🟩
Trunk Check runner [linux] 2m 🟩🟩
Repo Tests / Plugin Tests 1m 🟩🟩
Detect changed files 15s 🟩🟩
Aggregate Test Results 5s 🟥🟥

settingsfeedbackdocs ⋅ learn more about trunk.io

@TylerJang27 TylerJang27 requested review from det and gewenyu99 January 30, 2025 06:33
Copy link

trunk-staging-io bot commented Jan 30, 2025

Static BadgeStatic BadgeStatic BadgeStatic Badge

Failed Test Failure Summary Logs
Testing linter snyk test basic Snapshot mismatch error occurred during testing, with multiple issues found in JavaScript and Java files. Logs ↗︎

View Full Report ↗︎Docs

Copy link

Static BadgeStatic BadgeStatic BadgeStatic Badge

Failed Test Failure Summary Logs
Testing linter snyk test basic Snapshot mismatch error occurred during testing, with multiple issues found in JavaScript and Java files. Logs ↗︎

View Full Report ↗︎Docs

Copy link

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

Copy link

trunk-io bot commented Jan 30, 2025

Static BadgeStatic BadgeStatic BadgeStatic Badge

Failed Test Failure Summary Logs
Testing linter snyk test basic Some tests failed due to unexpected differences in the output, possibly caused by changes in the code or configuration. Logs ↗︎

View Full Report ↗︎Docs

@TylerJang27 TylerJang27 marked this pull request as ready for review January 30, 2025 18:02
linters/mypy/README.md Show resolved Hide resolved
linters/ruff/README.md Show resolved Hide resolved
x = 1
# trunk-ignore-end(ruff/F841)

# Unsupported in ruff

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooo Burnnnneeed Gotteeemmm

@TylerJang27 TylerJang27 merged commit 868bdc1 into main Jan 30, 2025
11 of 14 checks passed
@TylerJang27 TylerJang27 deleted the tyler/ignore-readme branch January 30, 2025 18:52
TylerJang27 added a commit that referenced this pull request Feb 3, 2025
Follow-up to #969. Adds instructions on adding comments with ignores, as
requested by user.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants