Add trussed-core crate #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sosthene-nitrokey @daringer Can you have a look this PR? I’d rather not have it open for too long as it touches lots of files and is prone to merge conflicts. |
|
A shame that because the original files are trimmed and not fully deleted, it doesn't show as a rename in the diff. I'm trusting the line count that nothing is missing. |
|
I’ve also tested this against nitrokey-3-firmware so I’m pretty sure that nothing is missing. But every rebase risks losing something. :( I’ll merge it now – updating the other PRs is hopefully trivial because |
|
Yes, updating these PRs will be much easier than rebasing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the trussed-core crate (#177) and moves the relevant modules fully or partially to it:
apiclient(only*Clientand mechanism traits as well as error and result types)config(only relevant constants)errorinterruptserde_extensions(only client traits and error and result types)types(only those types used by other modules)All moved types are re-exported from their old locations, so this is a compatible change for Trussed’s dependents.
As the extension request and reply serialization and deserialization is now split between(Edit: now done in #179)trussed-coreandtrussed, I’ve added serialization and deserialization methods to theExtensiontrait so thattrusseddoes not need to make assumptions about the serialization mechanism used bytrussed-core.We will probably want to make some more adjustments before releasing. This PR only intends to perform the split with minimal modifications.