Remove serde trait implementations for requests and replies #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sosthene-nitrokey
approved these changes
Dec 16, 2024
|
Seeing the need to implement this in two third-party crates, could this lead to an increase of binary size? |
|
Yes, in my tests this led to an increase of ~ 500 bytes. I thought that would just be acceptable. But we could also add |
|
I think we can do with 500B increase. |
|
But as we need the type in Trussed anyway (for the |
robin-nitrokey
force-pushed
the
api-serde
branch
from
1218f21 to
bb7d544
Compare
|
I’ve added |
Implementing Serialize and Deserialize for the request and reply structs leaks implementation details, especially when using serde_indexed. This patch removes these implementations for the request and reply structs and also for some other types that presumably only had them because they were used in these structs and that are not serialized or deserialized anywhere in the Trussed ecosystem. To make it easier to store encrypted data – where previously reply::Encrypt could be used direcly – this patch adds an EncryptedData struct that implemente Serialize and Deserialize. Fixes: #183
robin-nitrokey
force-pushed
the
api-serde
branch
from
bb7d544 to
df2867d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing Serialize and Deserialize for the request and reply structs leaks implementation details, especially when using serde_indexed. This patch removes these implementations for the request and reply structs and also for some other types that presumably only had them because they were used in these structs and that are not serialized or deserialized anywhere in the Trussed ecosystem.
Fixes: #183