core: Make more types non-exhaustive #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sosthene-nitrokey
approved these changes
Dec 19, 2024
This patch marks more types as non-exhaustive that could be extended in the future and that don’t need to be matched exhaustively: - KeySerialization - SignatureSerialization - consent::Error The only exhaustive types that could be realistically be extended in the future are now the request and reply structs. But marking these as non-exhaustive would make it very complex for the backends to implement these syscalls. We can try to find a solution for that when we think about alternative syscall implementations, e. g. using a builder pattern.
robin-nitrokey
force-pushed
the
exhaustive
branch
from
d40b2bf to
f97475e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch marks more types as non-exhaustive that could be extended in the future and that don’t need to be matched exhaustively:
KeySerializationSignatureSerializationconsent::ErrorThe only exhaustive types that could be realistically be extended in the future are now the request and reply structs. But marking these as non-exhaustive would make it very complex for the backends to implement these syscalls. We can try to find a solution for that when we think about alternative syscall implementations, e. g. using a builder pattern.