Fix compile-time mechanism checks #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robin-nitrokey
force-pushed
the
mechanism-check
branch
2 times, most recently
from
872f9ab to
0b44ea7
Compare
|
Updated to use a macro to generate the |
sosthene-nitrokey
requested changes
Jan 6, 2025
sosthene-nitrokey
approved these changes
Jan 6, 2025
To be able to compare mechanism variants in const contexts, we use add a const_eq function. And to be able to indicate which mechanism is potentially missing, we add a const panic method that includes the mechanism variant in the panic message. To reduce the boilerplate code, we use a macro to generate the enum.
robin-nitrokey
force-pushed
the
mechanism-check
branch
from
db58da3 to
2cd3cee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds missing variants to
trussed::types::IMPLEMENTED_MECHANISMSand makes it easier to validate the selected mechanisms at compile time.