Skip to content

Commit

Permalink
these need to not exist, this was the 'race condition' -- it was tryi…
Browse files Browse the repository at this point in the history
…ng to delete the bucket twice. Missed in the first pass of cleanup.
  • Loading branch information
esacteksab committed Jan 23, 2020
1 parent d828bbf commit 9e5f6c3
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 9 deletions.
3 changes: 0 additions & 3 deletions test/terraform_aws_logs_cloudtrail_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import (
"strings"
"testing"

"github.com/gruntwork-io/terratest/modules/aws"
"github.com/gruntwork-io/terratest/modules/random"
"github.com/gruntwork-io/terratest/modules/terraform"
)
Expand All @@ -31,7 +30,5 @@ func TestTerraformAwsLogsCloudtrail(t *testing.T) {
}

defer terraform.Destroy(t, terraformOptions)
// Empty and delete logs_bucket before terraform destroy
defer aws.DeleteS3Bucket(t, awsRegion, testName)
terraform.InitAndApply(t, terraformOptions)
}
2 changes: 0 additions & 2 deletions test/terraform_aws_logs_combined_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,5 @@ func TestTerraformAwsLogsCombined(t *testing.T) {
}

defer terraform.Destroy(t, terraformOptions)
// Empty and delete logs_bucket before terraform destroy
defer aws.DeleteS3Bucket(t, awsRegion, testName)
terraform.InitAndApply(t, terraformOptions)
}
4 changes: 0 additions & 4 deletions test/terraform_aws_logs_config_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import (
"strings"
"testing"

"github.com/gruntwork-io/terratest/modules/aws"
"github.com/gruntwork-io/terratest/modules/random"
"github.com/gruntwork-io/terratest/modules/terraform"
)
Expand All @@ -31,8 +30,5 @@ func TestTerraformAwsLogsConfig(t *testing.T) {
}

defer terraform.Destroy(t, terraformOptions)
// Empty and delete logs_bucket before terraform destroy
defer aws.DeleteS3Bucket(t, awsRegion, testName)
defer aws.EmptyS3Bucket(t, awsRegion, testName)
terraform.InitAndApply(t, terraformOptions)
}

0 comments on commit 9e5f6c3

Please sign in to comment.