Allow enabling/disabling IronTrail in rspec #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbrendel
approved these changes
Dec 6, 2024
| @enabled = true | ||
| end | ||
|
|
||
| def disable! |
There was a problem hiding this comment.
It's unlikely to happen since you need to require this, but one might do it in a rails console, I'd like iron_trail to protect me from doing this in production
There was a problem hiding this comment.
agreed. I'll add a protection if ENV['RAILS_ENV'] == 'production'
|
|
||
| require 'iron_trail/testing/rspec' | ||
|
|
||
| IronTrail::Testing.disable! |
There was a problem hiding this comment.
suggestion: also add a test where it is enabled by default, to ensure that iron_trail: false is working properly
There was a problem hiding this comment.
@peterbrendel done in dd27096
Co-authored-by: Peter Brendel <[email protected]>
peterbrendel
reviewed
Dec 6, 2024
Comment on lines
+3
to
+6
| if ENV['RAILS_ENV'] == 'production' | ||
| raise 'This file should not be required in production. ' \ | ||
| 'Change the RAILS_ENV env var temporarily to override this.' | ||
| end |
There was a problem hiding this comment.
Would raising here stop the application from booting?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira task
This PR adds functionality to enable/disable IronTrail in specs. See the README.md diff for more detail.