feat( RHOAIENG-20330): Update GuardrailsOrchestrator unit tests #418
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @artemsa223. Thanks for your PR. I'm waiting for a trustyai-explainability member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| APIVersion: "v1", | ||
| }, | ||
| ObjectMeta: metav1.ObjectMeta{ | ||
| Name: orchestratorName + "-config-1", |
There was a problem hiding this comment.
change to orchestratorName + "-1-config" bc in configmaps.go, we specify that the configmap needs to be ${orchestrator name}-config
| APIVersion: "v1", | ||
| }, | ||
| ObjectMeta: metav1.ObjectMeta{ | ||
| Name: orchestratorName + "-config-2", |
There was a problem hiding this comment.
change to orchestratorName + "-2-config"
| err = k8sClient.Create(ctx, configMap2) | ||
| Expect(err).ToNot(HaveOccurred()) | ||
|
|
||
| trustyAIConfigMap := &corev1.ConfigMap{ |
There was a problem hiding this comment.
you don't need to create the trustyAIConfigMap - if you pull the latest changes to main, then we specify the creation of the config map before each test
| Expect(err).ToNot(HaveOccurred()) | ||
| err = k8sClient.Delete(ctx, configMap2) | ||
| Expect(err).ToNot(HaveOccurred()) | ||
| err = k8sClient.Delete(ctx, trustyAIConfigMap) |
There was a problem hiding this comment.
for consistency, delete the trustyAIConfigMap by doing:
By("Deleting the TrustyAI configmap")
err = k8sClient.Delete(ctx, &corev1.ConfigMap{ObjectMeta: metav1.ObjectMeta{Name: constants.ConfigMap, Namespace: namespaceName}})
Expect(err).ToNot(HaveOccurred())
| err = k8sClient.Create(ctx, configMap2) | ||
| Expect(err).ToNot(HaveOccurred()) | ||
|
|
||
| trustyAIConfigMap1 := &corev1.ConfigMap{ |
There was a problem hiding this comment.
only 1 instance of the trustyAI configmap is needed and it is created before each test so delete this line
| err = k8sClient.Create(ctx, trustyAIConfigMap1) | ||
| Expect(err).ToNot(HaveOccurred()) | ||
|
|
||
| trustyAIConfigMap2 := &corev1.ConfigMap{ |
|
thanks for your PR @artemsa223 ! i've left some comments and before you address them, i would rebase on |
christinaexyou
changed the title
test: add unit tests for GuardrailsOrchestrator multi-instance scenarios