feat: add abby .js script #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
CakeWithDivinity
approved these changes
Dec 3, 2023
| typeof req.query.projectId === "string" && | ||
| req.query.projectId.endsWith(".js") | ||
| ) { | ||
| const jsContent = `window.${ABBY_WINDOW_KEY} = ${JSON.stringify( |
There was a problem hiding this comment.
Maybe we should sanitize this at some point, but this could be done in a seperate PR, if we want to quickly merge this now. You should just trust your colleagues :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the option to load the project data using a script via the API. This allows the browser in SPAs to load the data before the App is mounted and rendered. This can reduce a flash of content