Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix assignment and grading CORS issues on deployment and Update user service swagger and postman #117

Merged
merged 3 commits into from
Apr 19, 2024

Conversation

hhchinh2002
Copy link
Collaborator

Pull Request

Description

  • Fix assignment and grading CORS issues on deployment
  • Update user service swagger and postman

Related Issue(s)

Screenshots (if applicable)

Checklist

  • I have checked that the changes included in the PR are intended to merge to master or any destination branch.
  • I have verified that the new changes do not break any existing functionalities, unless the new changes are intended and have approved by the team.
  • I will take care of the merging and delete the side-branch after the PR is merged.

Additional Notes/References

Copy link

gitguardian bot commented Apr 19, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
10444735 Triggered Generic High Entropy Secret 85d3677 postman/user-microservice.postman_collection.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@tryyang2001
Copy link
Owner

Safe to ignore the so called "exposed" secret as long as it is just an example.

@hhchinh2002 hhchinh2002 merged commit a16bac0 into master Apr 19, 2024
10 checks passed
@hhchinh2002 hhchinh2002 deleted the User-Microservice branch April 19, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants