Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create upload endpoint #77

Merged
merged 8 commits into from
Apr 13, 2024
Merged

Create upload endpoint #77

merged 8 commits into from
Apr 13, 2024

Conversation

WillCWX
Copy link
Collaborator

@WillCWX WillCWX commented Apr 9, 2024

Pull Request

Description

Creates an upload endpoint with (uploadthing)[https://uploadthing.com/] for profile pictures

Adds uploadFiles utility that ProfileEditor uses during handleSubmit to update profile details.

Notes:

  • uploadthings added as a dependency, yarn install required
  • No authentication, will add in after integration
  • File verification done by uploadthing, might be sufficient

Related Issue(s)

Screenshots (if applicable)

image
image

Checklist

  • I have checked that the changes included in the PR are intended to merge to master or any destination branch.
  • I have verified that the new changes do not break any existing functionalities, unless the new changes are intended and have approved by the team.
  • I will take care of the merging and delete the side-branch after the PR is merged.

Additional Notes/References

@tryyang2001
Copy link
Owner

I have tested the upload image function, and it is working. However, I think you need to wait until @hhchinh2002 completed his user service integration, and you also want to polish the upload modal, can consider using the FileUpload component that I created, and also set and check the expected file types, and ensure the file image is less than, said 5MB.

@tryyang2001
Copy link
Owner

And another thing is the current branch is actually not working due to merge conflict and the database schema structure is accidentally changed by someone... Hence when you debug, please only run the user service and frontend. I will fix the problems when the user service integration is done.

@tryyang2001
Copy link
Owner

Tested uploading a profile pic, the upload is functioning correctly, but perhaps you forgot to update the SideBar to also include the new avatar update.

@hhchinh2002
Copy link
Collaborator

Tested uploading a profile pic, the upload is functioning correctly, but perhaps you forgot to update the SideBar to also include the new avatar update.

actually yall can merge this first and I'll update the sidebar to update user new avatar later in my PR

@tryyang2001
Copy link
Owner

actually yall can merge this first and I'll update the sidebar to update user new avatar later in my PR

Ermm sure, @WillCWX can you pull from master and resolve the merge conflicts before merging the PR :)

@WillCWX
Copy link
Collaborator Author

WillCWX commented Apr 13, 2024

actually yall can merge this first and I'll update the sidebar to update user new avatar later in my PR

Ermm sure, @WillCWX can you pull from master and resolve the merge conflicts before merging the PR :)

done, need approval, thanks

@WillCWX WillCWX merged commit 4c93231 into tryyang2001:master Apr 13, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants