Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: add some channel socket logics #71

Merged
merged 1 commit into from
Dec 13, 2023
Merged

WIP: add some channel socket logics #71

merged 1 commit into from
Dec 13, 2023

Conversation

cjho0316
Copy link
Contributor

채널 join이 안되는 이슈가 있어서 messageDTO에 channelId 추가했읍니다.

PrivateAlert구현 진행중에 있습니다

@cjho0316 cjho0316 requested a review from tomatozil December 13, 2023 06:40
@cjho0316 cjho0316 self-assigned this Dec 13, 2023
@tomatozil
Copy link
Contributor

좋아요 !

@@ -151,18 +151,18 @@ export class ChannelsGateway
const eventMessageEmitDto = {
nickname: user.nickname,
message,
channelId,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

notice도 기대가 됩니다

@tomatozil tomatozil merged commit 544f7b7 into main Dec 13, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants