New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: kick, ban, mute, admin 시 notice 소켓 이벤트 수정 #82

Merged

cjho0316 merged 1 commit into main from yubin

Dec 16, 2023

Contributor

yubinquitous commented Dec 16, 2023

kick, ban에서 channelId를 찾지 못하는 오류 수정
이미 삭제된 receiverChannelUser의 channelUserId 값을 이용해 channelId를 찾으려고 해서 발생하는 문제였습니다. giverUser의 userId 값을 이용해 channelId를 찾는 것으로 수정했습니다.
kick, ban, mute, admin 시 소켓의 nickname을 receiver의 nickname으로 수정 feat: channels socket 통신 구현 #52
프론트의 요청으로 수정했습니다.
머지하고 sangyeki한테 알려주시면 감사하겠습니당


          fix: kick, ban에서 channelId를 찾지 못하는 오류 수정, kick, ban, mute, admin 시 소켓…

…의 nickname을 receiverd의 nickname으로 수정 #52

yubinquitous added the FIX label

yubinquitous requested review from tomatozil and cjho0316

December 16, 2023 06:28

yubinquitous self-assigned this

cjho0316 approved these changes

View reviewed changes

Contributor

cjho0316 left a comment

LGTM

cjho0316 merged commit 5d1df4a into main

4 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FIX