Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completed version of vertex-gsoc-2024-assessment #5

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

dev-pa5an
Copy link

This pull request encompasses a comprehensive enhancement of the entire project, including the addition of unit test for BackendVerticle.
Screenshot 2024-03-26 at 11 40 17
Screenshot 2024-03-26 at 11 40 39
Looking forward to receiving feedback on my performance regarding this task. Thank you

Copy link
Owner

@tsegismont tsegismont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I made a first batch of comments.

Please read instructions carefully, one requirement is to create a commit for each task.

@dev-pa5an
Copy link
Author

dev-pa5an commented Mar 26, 2024

Thank you for reviewing my assessment. I addressed all the mentioned issues and suggestions and made a pull request from master branch. Thank you!

@dev-pa5an
Copy link
Author

I'll keep this PR open

@tsegismont
Copy link
Owner

Does this PR incorporate all your changes? Or are there changes in #6 that you need to apply here?

@dev-pa5an
Copy link
Author

No this PR incorporate all my changes

Copy link
Owner

@tsegismont tsegismont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @dev-pa5an

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants