Skip to content
This repository has been archived by the owner on Jul 3, 2021. It is now read-only.

Refining elliptic-grid-gen.jl #30

Merged

Conversation

Gravifer
Copy link
Member

@Gravifer Gravifer commented May 7, 2021

this supercedes and closes #26.

Gravifer and others added 17 commits May 4, 2021 12:50
The attempt is not effective; need serious effort attacking this with suitable source terms (基于源项的网格加密 #7).

BREAKING_CHANGE
also, added a newline at the end of build.jl
(cherry picked from commit df5f428caeec4fe4098a2b20edc174f94305c0c4, e07db602a3813add0deaa247a5d7b569dbaed0ef)
In limited times I merge this without sufficient discussion; revert if necessary.
@Gravifer Gravifer added enhancement New feature or request help wanted Extra attention is needed labels May 7, 2021
@Gravifer Gravifer added this to the 椭圆网格生成器 milestone May 7, 2021
@Gravifer Gravifer self-assigned this May 7, 2021
@pull-request-quantifier-deprecated

This PR has 330 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Large
Size       : +259 -71
Percentile : 73%

Total files changed: 9

Change summary by file extension:
.gitmodules : +3 -0
.json : +6 -1
.toml : +19 -2
.jl : +231 -68

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detetcted.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@Gravifer
Copy link
Member Author

Gravifer commented May 7, 2021

Still use a normal merge rather than squash to preserve full history.

@Gravifer Gravifer merged commit 200fe47 into tsinghua-TEEP:elliptic-grid-gen May 7, 2021
@Gravifer Gravifer deleted the elliptic-grid-gen branch May 7, 2021 09:43
@Gravifer Gravifer restored the elliptic-grid-gen branch May 7, 2021 09:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request help wanted Extra attention is needed Large
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant