This repository has been archived by the owner on Jul 3, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Refining elliptic-grid-gen.jl #30
Merged
Gravifer
merged 17 commits into
tsinghua-TEEP:elliptic-grid-gen
from
ZhuShaw-han:elliptic-grid-gen
May 7, 2021
Merged
Refining elliptic-grid-gen.jl #30
Gravifer
merged 17 commits into
tsinghua-TEEP:elliptic-grid-gen
from
ZhuShaw-han:elliptic-grid-gen
May 7, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is helpful for issue #3.
The attempt is not effective; need serious effort attacking this with suitable source terms (基于源项的网格加密 #7). BREAKING_CHANGE
also, added a newline at the end of build.jl (cherry picked from commit df5f428caeec4fe4098a2b20edc174f94305c0c4, e07db602a3813add0deaa247a5d7b569dbaed0ef)
…#7) is not yet implemented [skip ci]
In limited times I merge this without sufficient discussion; revert if necessary.
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
Still use a normal merge rather than squash to preserve full history. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this supercedes and closes #26.