Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update posix_poll.c: line 49 ppoll-->poll #125

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

drdink
Copy link

@drdink drdink commented Jan 22, 2025

aligned with posix_poll.h declaration

Wouldn't build until I changed typo.

aligned with posix_poll.h declaration
@Delofon
Copy link

Delofon commented Jan 23, 2025

pretty sure that's... not really a typo. not only it belongs to a different repo (GLFW which is pulled in as a dependency of raylib) poll and ppoll are two separate syscalls (rax 7 and 271 respectively) with different prototypes (so the way you did it you actually call poll incorrectly, it's better to remove the defined(__linux__) part from the #if directive to use generic code).
Now, the fact that this compilation error is there is nonetheless still odd as ppoll, according to its manpage, is declared in poll.h together with poll. If gcc errors on ppoll with implicit function declaration, then it also should error on poll, but it does not... so this needs to be investigated further (or not... whatever).
I don't think it's inherently a GLFW issue as I really believe uncompileable code wouldn't have hit main GLFW branch, so I guess it's something with the build system then...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants