Test fixes

tst-race · Dec 27, 2024 · 0d2edf5 · 0d2edf5
1 parent 579c47c
commit 0d2edf5
Show file tree

Hide file tree

Showing 44 changed files with 158 additions and 88 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -159,6 +159,18 @@ jobs:
           cache-from: ${{ steps.cache.outputs.cache-from }}
           cache-to: ${{ steps.cache.outputs.cache-to }}
 
+  run-tests:
+    needs: [compile-image]
+    runs-on: ubuntu-latest
+    container:
+      image: ghcr.io/tst-race/raceboat/raceboat-compile:${{ github.head_ref || github.ref_name }}
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v3
+
+      - name: Test
+        run: ./test.sh
+
   runtime-image:
     needs: [compile-image]
     runs-on: ubuntu-latest

diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -42,8 +42,8 @@ include(race/test-targets)
 include(race/valgrind)
 include(race/warnings)
 
-# setup_project_test_targets(raceSdkCommon UNIT INTEGRATION)
-# setup_project_format_targets(raceSdkCommon)
+setup_project_test_targets(raceSdkCommon UNIT INTEGRATION)
+setup_project_format_targets(raceSdkCommon)
 
 add_subdirectory(language-shims)
 add_subdirectory(source)

diff --git a/include/race/common/ChannelProperties.h b/include/race/common/ChannelProperties.h
@@ -14,8 +14,8 @@
 // limitations under the License.
 //
 
-#ifndef __CHANNEL_PROPERTIES_H_
-#define __CHANNEL_PROPERTIES_H_
+#ifndef CHANNEL_PROPERTIES_H
+#define CHANNEL_PROPERTIES_H
 
 #include <cstdint>
 #include <nlohmann/json.hpp>

diff --git a/include/race/common/ChannelRole.h b/include/race/common/ChannelRole.h
@@ -14,8 +14,8 @@
 // limitations under the License.
 //
 
-#ifndef __RACE_CHANNEL_ROLE_H_
-#define __RACE_CHANNEL_ROLE_H_
+#ifndef RACE_CHANNEL_ROLE_H
+#define RACE_CHANNEL_ROLE_H
 
 #include <string>
 #include <vector>

diff --git a/include/race/common/ChannelStatus.h b/include/race/common/ChannelStatus.h
@@ -14,8 +14,8 @@
 // limitations under the License.
 //
 
-#ifndef __RACE_CHANNEL_STATUS_H_
-#define __RACE_CHANNEL_STATUS_H_
+#ifndef RACE_CHANNEL_STATUS_H
+#define RACE_CHANNEL_STATUS_H
 
 #include <string>
 

diff --git a/include/race/common/ConnectionStatus.h b/include/race/common/ConnectionStatus.h
@@ -14,8 +14,8 @@
 // limitations under the License.
 //
 
-#ifndef __RACE_CONNECTION_STATUS_H_
-#define __RACE_CONNECTION_STATUS_H_
+#ifndef RACE_CONNECTION_STATUS_H
+#define RACE_CONNECTION_STATUS_H
 
 #include <iostream>
 #include <string>

diff --git a/include/race/common/ConnectionType.h b/include/race/common/ConnectionType.h
@@ -14,8 +14,8 @@
 // limitations under the License.
 //
 
-#ifndef __RACE_CONNECTION_TYPE_H_
-#define __RACE_CONNECTION_TYPE_H_
+#ifndef RACE_CONNECTION_TYPE_H
+#define RACE_CONNECTION_TYPE_H
 
 #include <string>
 

diff --git a/include/race/common/EncPkg.h b/include/race/common/EncPkg.h
@@ -14,8 +14,8 @@
 // limitations under the License.
 //
 
-#ifndef __ENC_PKG_
-#define __ENC_PKG_
+#ifndef ENC_PKG
+#define ENC_PKG
 
 #include <cstdint>
 #include <string>

diff --git a/include/race/common/LinkProperties.h b/include/race/common/LinkProperties.h
@@ -14,8 +14,8 @@
 // limitations under the License.
 //
 
-#ifndef __LINK_PROPERTIES_H_
-#define __LINK_PROPERTIES_H_
+#ifndef LINK_PROPERTIES_H
+#define LINK_PROPERTIES_H
 
 #include <cstdint>
 #include <string>

diff --git a/include/race/common/LinkPropertyPair.h b/include/race/common/LinkPropertyPair.h
@@ -14,8 +14,8 @@
 // limitations under the License.
 //
 
-#ifndef __LINK_PROPERTY_PAIR_H_
-#define __LINK_PROPERTY_PAIR_H_
+#ifndef LINK_PROPERTY_PAIR_H
+#define LINK_PROPERTY_PAIR_H
 
 #include <cstdint>
 #include <string>

diff --git a/include/race/common/LinkPropertySet.h b/include/race/common/LinkPropertySet.h
@@ -14,8 +14,8 @@
 // limitations under the License.
 //
 
-#ifndef __LINK_PROPERTY_SET_H_
-#define __LINK_PROPERTY_SET_H_
+#ifndef LINK_PROPERTY_SET_H
+#define LINK_PROPERTY_SET_H
 
 #include <cstdint>
 #include <string>

diff --git a/include/race/common/LinkStatus.h b/include/race/common/LinkStatus.h
@@ -14,8 +14,8 @@
 // limitations under the License.
 //
 
-#ifndef __RACE_LINK_STATUS_H_
-#define __RACE_LINK_STATUS_H_
+#ifndef RACE_LINK_STATUS_H
+#define RACE_LINK_STATUS_H
 
 #include <iostream>
 #include <string>

diff --git a/include/race/common/LinkType.h b/include/race/common/LinkType.h
@@ -14,8 +14,8 @@
 // limitations under the License.
 //
 
-#ifndef __RACE_LINK_TYPE_H_
-#define __RACE_LINK_TYPE_H_
+#ifndef RACE_LINK_TYPE_H
+#define RACE_LINK_TYPE_H
 
 #include <string>
 

diff --git a/include/race/common/PackageStatus.h b/include/race/common/PackageStatus.h
@@ -14,8 +14,8 @@
 // limitations under the License.
 //
 
-#ifndef __RACE_PACKAGE_STATUS_H_
-#define __RACE_PACKAGE_STATUS_H_
+#ifndef RACE_PACKAGE_STATUS_H
+#define RACE_PACKAGE_STATUS_H
 
 #include <string>
 

diff --git a/include/race/common/PackageType.h b/include/race/common/PackageType.h
@@ -14,8 +14,8 @@
 // limitations under the License.
 //
 
-#ifndef __RACE_PACKAGE_TYPE_H_
-#define __RACE_PACKAGE_TYPE_H_
+#ifndef RACE_PACKAGE_TYPE_H
+#define RACE_PACKAGE_TYPE_H
 
 #include <string>
 

diff --git a/include/race/common/PluginConfig.h b/include/race/common/PluginConfig.h
@@ -14,8 +14,8 @@
 // limitations under the License.
 //
 
-#ifndef __PLUGIN_CONFIG_H_
-#define __PLUGIN_CONFIG_H_
+#ifndef PLUGIN_CONFIG_H
+#define PLUGIN_CONFIG_H
 
 #include <string>
 

diff --git a/include/race/common/PluginResponse.h b/include/race/common/PluginResponse.h
@@ -14,8 +14,8 @@
 // limitations under the License.
 //
 
-#ifndef __RACE_PLUGIN_RESPONSE_H_
-#define __RACE_PLUGIN_RESPONSE_H_
+#ifndef RACE_PLUGIN_RESPONSE_H
+#define RACE_PLUGIN_RESPONSE_H
 
 #include <string>
 

diff --git a/include/race/common/RaceEnums.h b/include/race/common/RaceEnums.h
@@ -14,8 +14,8 @@
 // limitations under the License.
 //
 
-#ifndef __RACE_ENUMS_H_
-#define __RACE_ENUMS_H_
+#ifndef RACE_ENUMS_H
+#define RACE_ENUMS_H
 
 #include <string>
 
@@ -75,4 +75,4 @@ enum BootstrapActionType {
 
 } // namespace RaceEnums
 
-#endif
+#endif
diff --git a/include/race/common/RaceExport.h b/include/race/common/RaceExport.h
@@ -14,8 +14,8 @@
 // limitations under the License.
 //
 
-#ifndef __EXPORTS_H_
-#define __EXPORTS_H_
+#ifndef EXPORTS_H
+#define EXPORTS_H
 
 #if defined(_WIN32)
 #define EXPORT __declspec(dllexport)

diff --git a/include/race/common/RacePluginExports.h b/include/race/common/RacePluginExports.h
@@ -14,8 +14,8 @@
 // limitations under the License.
 //
 
-#ifndef __RACE_PLUGIN_EXPORTS_H_
-#define __RACE_PLUGIN_EXPORTS_H_
+#ifndef RACE_PLUGIN_EXPORTS_H
+#define RACE_PLUGIN_EXPORTS_H
 
 #include "RaceExport.h"
 

diff --git a/include/race/common/SendType.h b/include/race/common/SendType.h
@@ -14,8 +14,8 @@
 // limitations under the License.
 //
 
-#ifndef __RACE_SEND_TYPE_H_
-#define __RACE_SEND_TYPE_H_
+#ifndef RACE_SEND_TYPE_H
+#define RACE_SEND_TYPE_H
 
 #include <string>
 

diff --git a/include/race/common/TransmissionType.h b/include/race/common/TransmissionType.h
@@ -14,8 +14,8 @@
 // limitations under the License.
 //
 
-#ifndef __RACE_TRANSMISSION_TYPE_H_
-#define __RACE_TRANSMISSION_TYPE_H_
+#ifndef RACE_TRANSMISSION_TYPE_H
+#define RACE_TRANSMISSION_TYPE_H
 
 #include <string>
 

diff --git a/include/race/decomposed/ComponentTypes.h b/include/race/decomposed/ComponentTypes.h
@@ -15,8 +15,8 @@
 // limitations under the License.
 //
 
-#ifndef __I_COMPONENT_TYPES_H__
-#define __I_COMPONENT_TYPES_H__
+#ifndef I_COMPONENT_TYPES_H
+#define I_COMPONENT_TYPES_H
 
 #include <string>
 #include <unordered_map>

diff --git a/include/race/decomposed/IComponentBase.h b/include/race/decomposed/IComponentBase.h
@@ -15,8 +15,8 @@
 // limitations under the License.
 //
 
-#ifndef __I_COMPONENT_BASE_H__
-#define __I_COMPONENT_BASE_H__
+#ifndef I_COMPONENT_BASE_H_
+#define I_COMPONENT_BASE_H_
 
 #include "ComponentTypes.h"
 

diff --git a/include/race/decomposed/IComponentSdkBase.h b/include/race/decomposed/IComponentSdkBase.h
@@ -15,8 +15,8 @@
 // limitations under the License.
 //
 
-#ifndef __I_COMPONENT_SDK_BASE_H__
-#define __I_COMPONENT_SDK_BASE_H__
+#ifndef I_COMPONENT_SDK_BASE_H_
+#define I_COMPONENT_SDK_BASE_H_
 
 #include "IComponentBase.h"
 

diff --git a/include/race/decomposed/IEncodingComponent.h b/include/race/decomposed/IEncodingComponent.h
@@ -15,8 +15,8 @@
 // limitations under the License.
 //
 
-#ifndef __I_ENCODING_COMPONENT_H__
-#define __I_ENCODING_COMPONENT_H__
+#ifndef I_ENCODING_COMPONENT_H_
+#define I_ENCODING_COMPONENT_H_
 
 #include "PluginConfig.h"
 #include "RacePluginExports.h"

diff --git a/include/race/decomposed/IEncodingSdk.h b/include/race/decomposed/IEncodingSdk.h
@@ -15,8 +15,8 @@
 // limitations under the License.
 //
 
-#ifndef __I_ENCODING_SDK_H__
-#define __I_ENCODING_SDK_H__
+#ifndef I_ENCODING_SDK_H_
+#define I_ENCODING_SDK_H_
 
 #include <vector>
 

diff --git a/include/race/decomposed/ITransportComponent.h b/include/race/decomposed/ITransportComponent.h
@@ -15,8 +15,8 @@
 // limitations under the License.
 //
 
-#ifndef __I_TRANSPORT_COMPONENT_H__
-#define __I_TRANSPORT_COMPONENT_H__
+#ifndef I_TRANSPORT_COMPONENT_H_
+#define I_TRANSPORT_COMPONENT_H_
 
 #include "LinkProperties.h"
 #include "PluginConfig.h"

diff --git a/include/race/decomposed/ITransportSdk.h b/include/race/decomposed/ITransportSdk.h
@@ -15,8 +15,8 @@
 // limitations under the License.
 //
 
-#ifndef __I_TRANSPORT_SDK_H__
-#define __I_TRANSPORT_SDK_H__
+#ifndef I_TRANSPORT_SDK_H_
+#define I_TRANSPORT_SDK_H_
 
 #include "ChannelProperties.h"
 #include "LinkStatus.h"

diff --git a/include/race/decomposed/IUserModelComponent.h b/include/race/decomposed/IUserModelComponent.h
@@ -15,8 +15,8 @@
 // limitations under the License.
 //
 
-#ifndef __I_USER_MODEL_COMPONENT_H__
-#define __I_USER_MODEL_COMPONENT_H__
+#ifndef I_USER_MODEL_COMPONENT_H_
+#define I_USER_MODEL_COMPONENT_H_
 
 #include "PluginConfig.h"
 #include "RacePluginExports.h"

diff --git a/include/race/decomposed/IUserModelSdk.h b/include/race/decomposed/IUserModelSdk.h
@@ -15,8 +15,8 @@
 // limitations under the License.
 //
 
-#ifndef __I_USER_MODEL_SDK_H__
-#define __I_USER_MODEL_SDK_H__
+#ifndef I_USER_MODEL_SDK_H_
+#define I_USER_MODEL_SDK_H_
 
 #include "IComponentSdkBase.h"
 

diff --git a/include/race/unified/IRacePluginComms.h b/include/race/unified/IRacePluginComms.h
@@ -14,8 +14,8 @@
 // limitations under the License.
 //
 
-#ifndef __I_RACE_PLUGIN_COMMS_H_
-#define __I_RACE_PLUGIN_COMMS_H_
+#ifndef I_RACE_PLUGIN_COMMS_H
+#define I_RACE_PLUGIN_COMMS_H
 
 #include <string>
 

diff --git a/include/race/unified/IRaceSdkCommon.h b/include/race/unified/IRaceSdkCommon.h
@@ -14,8 +14,8 @@
 // limitations under the License.
 //
 
-#ifndef __I_RACE_SDK_COMMON_H_
-#define __I_RACE_SDK_COMMON_H_
+#ifndef I_RACE_SDK_COMMON_H
+#define I_RACE_SDK_COMMON_H
 
 #include <cstdint>
 #include <limits>

diff --git a/include/race/unified/IRaceSdkComms.h b/include/race/unified/IRaceSdkComms.h
@@ -14,8 +14,8 @@
 // limitations under the License.
 //
 
-#ifndef __I_RACE_SDK_COMMS_H_
-#define __I_RACE_SDK_COMMS_H_
+#ifndef I_RACE_SDK_COMMS_H
+#define I_RACE_SDK_COMMS_H
 
 #include <vector>
 

diff --git a/race-cmake-modules/race/lint.cmake b/race-cmake-modules/race/lint.cmake
@@ -38,7 +38,6 @@ function(setup_clang_tidy_for_target)
         set(CLANG_TIDY_CMD
             clang-tidy-15
             -checks=${CLANG_TIDY_CHECKS}
-            -warnings-as-errors=*
             -header-filter=.*
         )
         set_target_properties(${CLANG_TIDY_TARGET} PROPERTIES CXX_CLANG_TIDY "${CLANG_TIDY_CMD}")