Fix printing of time_t values.
#1161
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no guarantee that `time_t` is a `long int`. On NetBSD, `time_t` is a `long long int`. And ... apparently there is no portable way to indicate a printf format for a `time_t` via sys/inttypes.h / int_fmtio.h. So do the next best thing to improve portability to NetBSD and avoid the warning about mismatched format and argument type (-Wformat) by casting `time_t` to `long long` before printing, and use %lld as the format specifier. In a similar vein, there's also no portable way to specify a suitable format for a `size_t`, so cast to `long unsigned int` and print with %lu.
tstack
reviewed
May 25, 2023
| @@ -624,7 +624,7 @@ execute_file(exec_context& ec, const std::string& path_and_args, bool multiline) | |||
|
|
|||
| vars["#"] = env_arg_name; | |||
| for (size_t lpc = 0; lpc < split_args.size(); lpc++) { | |||
| snprintf(env_arg_name, sizeof(env_arg_name), "%lu", lpc); | |||
| snprintf(env_arg_name, sizeof(env_arg_name), "%lu", (long unsigned int)lpc); | |||
There was a problem hiding this comment.
I believe there's a z length modifier, so this should be %zu and then you don't need to cast it.
There was a problem hiding this comment.
You are correct -- removing the suggested cast and using "z" format works as well for this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no guarantee that
time_tis along int. On NetBSD,time_tis along long int. And ... apparently there is no portable way to indicate a printf format for atime_tvia sys/inttypes.h / int_fmtio.h.So do the next best thing to improve portability to NetBSD and avoid the warning about mismatched format and argument type (-Wformat) by casting
time_ttolong longbefore printing, and use %lld as the format specifier.In a similar vein, there's also no portable way to specify a suitable format for a
size_t, so cast tolong unsigned intand print with %lu.