Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update qhimm.xml - Add 60 FPS ChaOS Animations mod #181

Merged
merged 2 commits into from
Sep 8, 2024

Conversation

KuraudoXS
Copy link
Contributor

Add "60 FPS ChaOS Animations" mod - Sephiroth 60 FPS fix by Kaldarasha. I've also got the green light from Kaldarasha.

Add "60 FPS ChaOS Animations" mod - Sephiroth 60 FPS fix by Kaldarasha. I've also got the green light from Kaldarasha.
@wturner859
Copy link
Contributor

wturner859 commented Aug 29, 2024

Doesn't the main 60 FPS mod already have a selection for CHAOS? If it's just a fix, perhaps it should go straight into the 60 FPS mod rather than putting a whole new mod in the catalog @tangtang95

@wturner859
Copy link
Contributor

@tangtang95 incase edited messages don't send pings.

Add "60 FPS ChaOS Animations" mod - Sephiroth 60 FPS fix by Kaldarasha. I've also got the green light from Kaldarasha. 

Reverted back ID.
@tangtang95
Copy link
Contributor

I did not want to add to 60 fps mod because the option in 60 fps advanced field animation is for giving a style to animations (one can use ninostyle hd animations with original 3d models to add breathing animation). Also this mod is fixing an issue happening only with Chaos because its Sephiroth model has a different skeleton.

In the end, if added it would add a new option which depends on chaos and on either side this option cannot be enabled automatically since it's a weak dependency rather than strict dependency. The same has been done for 60 fps new threat mod: by making it a mod by itself it can have strict dependency and automatically activate 60 fps and new threat mod

@KuraudoXS
Copy link
Contributor Author

@wturner859 any update on the aforementioned?

@strife98 strife98 merged commit d63d4a5 into tsunamods-codes:master Sep 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants